From: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: netdev@vger.kernel.org, e1000-devel@lists.sourceforge.net,
Steve Glendinning <steve.glendinning@smsc.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Rasesh Mody <rmody@brocade.com>,
Debashis Dutt <ddutt@brocade.com>,
Kristoffer Glembo <kristoffer@gaisler.com>,
linux-driver@qlogic.com, linux-net-drivers@solarflare.com
Subject: Re: [PATCH 2/4] Ethtool: convert get_sg/set_sg calls to hw_features flag
Date: Tue, 2 Nov 2010 01:59:52 +0100 [thread overview]
Message-ID: <20101102005952.GB15848@rere.qmqm.pl> (raw)
In-Reply-To: <1288646150.2231.62.camel@achroite.uk.solarflarecom.com>
On Mon, Nov 01, 2010 at 09:15:50PM +0000, Ben Hutchings wrote:
> On Sat, 2010-10-30 at 06:28 +0200, Michał Mirosław wrote:
> [...]
> > @@ -1088,7 +1076,19 @@ static int __ethtool_set_sg(struct net_device *dev, u32 data)
> > if (err)
> > return err;
> > }
> > - return dev->ethtool_ops->set_sg(dev, data);
> > +
> > + if (dev->ethtool_ops->hw_set_sg) {
> > + err = dev->ethtool_ops->hw_set_sg(dev, data);
> > + if (err)
> > + return min(err, 0);
> > + }
> > +
> > + if (data)
> > + dev->features |= NETIF_F_SG;
> > + else
> > + dev->features &= ~NETIF_F_SG;
> > +
> > + return 0;
> > }
> [...]
>
> The odd semantics of positive return values really need to be documented
> - both in the commit message and in the comment on struct ethtool_ops.
Will do.
Best Regards,
Michał Mirosław
next prev parent reply other threads:[~2010-11-02 0:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-31 3:40 [PATCH 0/4] Ethtool: cleanup strategy Michał Mirosław
2010-10-30 4:27 ` [PATCH 1/4] Ethtool: Introduce hw_features field in struct netdevice Michał Mirosław
2010-10-30 4:28 ` [PATCH 2/4] Ethtool: convert get_sg/set_sg calls to hw_features flag Michał Mirosław
2010-11-01 21:15 ` Ben Hutchings
2010-11-02 0:59 ` Michał Mirosław [this message]
2010-11-02 2:24 ` Matt Carlson
2010-11-03 22:29 ` Micha?? Miros??aw
2010-11-03 22:42 ` Matt Carlson
2010-11-03 22:58 ` Michał Mirosław
2010-10-30 8:44 ` [PATCH 3/4] Ethtool: convert get_tso/set_tso calls to hw_features flags Michał Mirosław
2010-11-01 21:25 ` Ben Hutchings
2010-11-02 1:14 ` Michał Mirosław
2010-11-02 2:49 ` Matt Carlson
2010-10-31 0:09 ` [PATCH 4/4] Ethtool: convert get_tx_csum/set_tx_csum " Michał Mirosław
2010-11-01 21:38 ` Ben Hutchings
2010-11-02 1:23 ` Michał Mirosław
2010-10-31 4:18 ` [PATCH 0/4] Ethtool: cleanup strategy David Miller
2010-10-31 4:30 ` Michał Mirosław
2010-11-01 21:05 ` Ben Hutchings
2010-11-02 1:02 ` Michał Mirosław
2010-11-02 1:14 ` Ben Hutchings
2010-11-02 1:30 ` Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101102005952.GB15848@rere.qmqm.pl \
--to=mirq-linux@rere.qmqm.pl \
--cc=bhutchings@solarflare.com \
--cc=ddutt@brocade.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=gregkh@suse.de \
--cc=kristoffer@gaisler.com \
--cc=linux-driver@qlogic.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=rmody@brocade.com \
--cc=steve.glendinning@smsc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.