From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Olsa Subject: Re: [PATCH 1/3] cgroup - removing superfluous rcu_read_lock_held check Date: Wed, 3 Nov 2010 09:58:04 +0100 Message-ID: <20101103085804.GB1916@jolsa.brq.redhat.com> References: <1288638909-10541-1-git-send-email-jolsa@redhat.com> <1288638909-10541-2-git-send-email-jolsa@redhat.com> <4CD0506F.6080600@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <4CD0506F.6080600-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Li Zefan Cc: dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: containers.vger.kernel.org T24gV2VkLCBOb3YgMDMsIDIwMTAgYXQgMDE6NTQ6NTVBTSArMDgwMCwgTGkgWmVmYW4gd3JvdGU6 Cj4gT24gMjAxMOW5tDEx5pyIMDLml6UgMDM6MTUsIEppcmkgT2xzYSB3cm90ZToKPiA+IGhpLAo+ IAo+IFRoaXMuLgo+IAo+ID4gdGhlIHJjdV9kZXJlZmVyZW5jZV9jaGVjayBpcyBkZWZpbmVkIGFz Cj4gPiAKPiA+IAkjZGVmaW5lIHJjdV9kZXJlZmVyZW5jZV9jaGVjayhwLCBjKSBcCj4gPiAJICAg X19yY3VfZGVyZWZlcmVuY2VfY2hlY2soKHApLCByY3VfcmVhZF9sb2NrX2hlbGQoKSB8fCAoYyks IF9fcmN1KQo+ID4gCj4gPiBzbyB0aGUgY2FsbGVyIGRvZXMgbm90IG5lZWQgdG8gc3BlY2lmeSBy Y3VfcmVhZF9sb2NrX2hlbGQoKSBjb25kaXRpb24uCj4gPgo+ICAKPiA+IHdiciwKPiA+IGppcmth Cj4gCj4gYW5kIHRoaXMgc2hvdWxkIGJlIGV4Y2x1ZGVkIGZyb20gdGhlIGNoYW5nZWxvZy4KPiAK PiA+IAo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBKaXJpIE9sc2EgPGpvbHNhQHJlZGhhdC5jb20+ Cj4gCj4gUmV2aWV3ZWQtYnk6IExpIFplZmFuIDxsaXpmQGNuLmZ1aml0c3UuY29tPgo+IAo+IEhv d2V2ZXIgYSBuaXRwaWNrOgo+IAo+ID4gLS0tCj4gPiAgaW5jbHVkZS9saW51eC9jZ3JvdXAuaCB8 ICAgIDEgLQo+ID4gIGtlcm5lbC9jZ3JvdXAuYyAgICAgICAgfCAgICA2ICsrLS0tLQo+ID4gIDIg ZmlsZXMgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQo+IC4uLgo+ID4g QEAgLTQ1NDQsNyArNDU0Miw3IEBAIHVuc2lnbmVkIHNob3J0IGNzc19pZChzdHJ1Y3QgY2dyb3Vw X3N1YnN5c19zdGF0ZSAqY3NzKQo+ID4gIAkgKiBpdCdzIHVuY2hhbmdlZCB1bnRpbCBmcmVlZC4K PiA+ICAJICovCj4gPiAgCWNzc2lkID0gcmN1X2RlcmVmZXJlbmNlX2NoZWNrKGNzcy0+aWQsCj4g PiAtCQkJcmN1X3JlYWRfbG9ja19oZWxkKCkgfHwgYXRvbWljX3JlYWQoJmNzcy0+cmVmY250KSk7 Cj4gPiArCQkJYXRvbWljX3JlYWQoJmNzcy0+cmVmY250KSk7Cj4gCj4gTm93IHRoZSAyIGxpbmVz IGNhbiBiZSBtYWRlIGludG8gb25lIGxpbmUgYW5kIHN0aWxsIGZpdCBpbnRvIDgwIGNoYXJzLgo+ IAo+ID4gIAo+ID4gIAlpZiAoY3NzaWQpCj4gPiAgCQlyZXR1cm4gY3NzaWQtPmlkOwo+ID4gQEAg LTQ1NTcsNyArNDU1NSw3IEBAIHVuc2lnbmVkIHNob3J0IGNzc19kZXB0aChzdHJ1Y3QgY2dyb3Vw X3N1YnN5c19zdGF0ZSAqY3NzKQo+ID4gIAlzdHJ1Y3QgY3NzX2lkICpjc3NpZDsKPiA+ICAKPiA+ ICAJY3NzaWQgPSByY3VfZGVyZWZlcmVuY2VfY2hlY2soY3NzLT5pZCwKPiA+IC0JCQlyY3VfcmVh ZF9sb2NrX2hlbGQoKSB8fCBhdG9taWNfcmVhZCgmY3NzLT5yZWZjbnQpKTsKPiA+ICsJCQlhdG9t aWNfcmVhZCgmY3NzLT5yZWZjbnQpKTsKPiAKPiBkaXRvCj4gCj4gPiAgCj4gPiAgCWlmIChjc3Np ZCkKPiA+ICAJCXJldHVybiBjc3NpZC0+ZGVwdGg7CgphdHRhY2hpbmcgY2hhbmdlZCBwYXRjaAoK d2JyLApqaXJrYQoKLS0tCk5vIG5lZWQgdG8gc3BlY2lmeSByY3VfcmVhZF9sb2NrX2hlbGQoKSBj b25kaXRpb24gaW4gcmN1X2RlcmVmZXJlbmNlX2NoZWNrLgoKClNpZ25lZC1vZmYtYnk6IEppcmkg T2xzYSA8am9sc2FAcmVkaGF0LmNvbT4KLS0tCiBpbmNsdWRlL2xpbnV4L2Nncm91cC5oIHwgICAg MSAtCiBrZXJuZWwvY2dyb3VwLmMgICAgICAgIHwgICAgOCArKy0tLS0tLQogMiBmaWxlcyBjaGFu Z2VkLCAyIGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvaW5jbHVk ZS9saW51eC9jZ3JvdXAuaCBiL2luY2x1ZGUvbGludXgvY2dyb3VwLmgKaW5kZXggZWQ0YmExMS4u Y2FlZDU2OCAxMDA2NDQKLS0tIGEvaW5jbHVkZS9saW51eC9jZ3JvdXAuaAorKysgYi9pbmNsdWRl L2xpbnV4L2Nncm91cC5oCkBAIC01MzYsNyArNTM2LDYgQEAgc3RhdGljIGlubGluZSBzdHJ1Y3Qg Y2dyb3VwX3N1YnN5c19zdGF0ZSAqY2dyb3VwX3N1YnN5c19zdGF0ZSgKICAqLwogI2RlZmluZSB0 YXNrX3N1YnN5c19zdGF0ZV9jaGVjayh0YXNrLCBzdWJzeXNfaWQsIF9fYykJCQlcCiAJcmN1X2Rl cmVmZXJlbmNlX2NoZWNrKHRhc2stPmNncm91cHMtPnN1YnN5c1tzdWJzeXNfaWRdLAkJXAotCQkJ ICAgICAgcmN1X3JlYWRfbG9ja19oZWxkKCkgfHwJCQlcCiAJCQkgICAgICBsb2NrZGVwX2lzX2hl bGQoJnRhc2stPmFsbG9jX2xvY2spIHx8CVwKIAkJCSAgICAgIGNncm91cF9sb2NrX2lzX2hlbGQo KSB8fCAoX19jKSkKIApkaWZmIC0tZ2l0IGEva2VybmVsL2Nncm91cC5jIGIva2VybmVsL2Nncm91 cC5jCmluZGV4IDY2YTQxNmIuLmE4ZDIyMjEgMTAwNjQ0Ci0tLSBhL2tlcm5lbC9jZ3JvdXAuYwor KysgYi9rZXJuZWwvY2dyb3VwLmMKQEAgLTE2ODcsNyArMTY4Nyw2IEBAIGludCBjZ3JvdXBfcGF0 aChjb25zdCBzdHJ1Y3QgY2dyb3VwICpjZ3JwLCBjaGFyICpidWYsIGludCBidWZsZW4pCiB7CiAJ Y2hhciAqc3RhcnQ7CiAJc3RydWN0IGRlbnRyeSAqZGVudHJ5ID0gcmN1X2RlcmVmZXJlbmNlX2No ZWNrKGNncnAtPmRlbnRyeSwKLQkJCQkJCSAgICAgIHJjdV9yZWFkX2xvY2tfaGVsZCgpIHx8CiAJ CQkJCQkgICAgICBjZ3JvdXBfbG9ja19pc19oZWxkKCkpOwogCiAJaWYgKCFkZW50cnkgfHwgY2dy cCA9PSBkdW1teXRvcCkgewpAQCAtMTcxMyw3ICsxNzEyLDYgQEAgaW50IGNncm91cF9wYXRoKGNv bnN0IHN0cnVjdCBjZ3JvdXAgKmNncnAsIGNoYXIgKmJ1ZiwgaW50IGJ1ZmxlbikKIAkJCWJyZWFr OwogCiAJCWRlbnRyeSA9IHJjdV9kZXJlZmVyZW5jZV9jaGVjayhjZ3JwLT5kZW50cnksCi0JCQkJ CSAgICAgICByY3VfcmVhZF9sb2NrX2hlbGQoKSB8fAogCQkJCQkgICAgICAgY2dyb3VwX2xvY2tf aXNfaGVsZCgpKTsKIAkJaWYgKCFjZ3JwLT5wYXJlbnQpCiAJCQljb250aW51ZTsKQEAgLTQ1NDMs OCArNDU0MSw3IEBAIHVuc2lnbmVkIHNob3J0IGNzc19pZChzdHJ1Y3QgY2dyb3VwX3N1YnN5c19z dGF0ZSAqY3NzKQogCSAqIG9uIHRoaXMgb3IgdGhpcyBpcyB1bmRlciByY3VfcmVhZF9sb2NrKCku IE9uY2UgY3NzLT5pZCBpcyBhbGxvY2F0ZWQsCiAJICogaXQncyB1bmNoYW5nZWQgdW50aWwgZnJl ZWQuCiAJICovCi0JY3NzaWQgPSByY3VfZGVyZWZlcmVuY2VfY2hlY2soY3NzLT5pZCwKLQkJCXJj dV9yZWFkX2xvY2tfaGVsZCgpIHx8IGF0b21pY19yZWFkKCZjc3MtPnJlZmNudCkpOworCWNzc2lk ID0gcmN1X2RlcmVmZXJlbmNlX2NoZWNrKGNzcy0+aWQsIGF0b21pY19yZWFkKCZjc3MtPnJlZmNu dCkpOwogCiAJaWYgKGNzc2lkKQogCQlyZXR1cm4gY3NzaWQtPmlkOwpAQCAtNDU1Niw4ICs0NTUz LDcgQEAgdW5zaWduZWQgc2hvcnQgY3NzX2RlcHRoKHN0cnVjdCBjZ3JvdXBfc3Vic3lzX3N0YXRl ICpjc3MpCiB7CiAJc3RydWN0IGNzc19pZCAqY3NzaWQ7CiAKLQljc3NpZCA9IHJjdV9kZXJlZmVy ZW5jZV9jaGVjayhjc3MtPmlkLAotCQkJcmN1X3JlYWRfbG9ja19oZWxkKCkgfHwgYXRvbWljX3Jl YWQoJmNzcy0+cmVmY250KSk7CisJY3NzaWQgPSByY3VfZGVyZWZlcmVuY2VfY2hlY2soY3NzLT5p ZCwgYXRvbWljX3JlYWQoJmNzcy0+cmVmY250KSk7CiAKIAlpZiAoY3NzaWQpCiAJCXJldHVybiBj c3NpZC0+ZGVwdGg7Ci0tIAoxLjcuMQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KQ29udGFpbmVycyBtYWlsaW5nIGxpc3QKQ29udGFpbmVyc0BsaXN0cy5s aW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnL21h aWxtYW4vbGlzdGluZm8vY29udGFpbmVycw==