Re: [v2 PATCH 0/4] IPVS: Backup Adding Ipv6 and Persistence support

[Simon Horman <horms@verge.net.au>]

On Tue, Nov 09, 2010 at 01:19:54AM +0200, Julian Anastasov wrote:
> 
> 	Hello,
> 
> On Tue, 9 Nov 2010, Simon Horman wrote:
> 
> >I have added this and the other patches that I am completely happy with
> >to the staging branch of lvs-test-2.6.
> >
> >Specifically the patches in there are:
> >
> >* IPVS: Only match pe_data created by the same pe
> >* IPVS: Add persistence engine to connection entry
> >* IPVS: Backup, Adding structs for new sync format
> >* IPVS: Prepare for transferring firewall marks (fwmark) to the backup daemon.
> >* IPVS: ip_vs_pe.c, use strncmp to be safe.
> 
> 	Using if (strncmp(pe_name, pe->name, IP_VS_PENAME_MAXLEN )==0
> does not look useful. If the goal is to match data from
> sync message I expect to see the already discussed check
> for pe_name_len, for example:
> 
> if (!strncmp(pe_name, pe->name, pe_name_len) &&
>     !pe->name[pe_name_len])
> 
> 	and somewhere check for pe_name_len > 0.

To be honest, I am a bit dubious about the need for strncmp() at all.
I think it all depends on how/if pe_name can be trusted.
And I think that will depend on how Hans codes up the synchronisation code.