From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756850Ab0KJQLO (ORCPT ); Wed, 10 Nov 2010 11:11:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:4682 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756463Ab0KJQLN (ORCPT ); Wed, 10 Nov 2010 11:11:13 -0500 Date: Wed, 10 Nov 2010 17:08:38 +0100 From: Andrea Arcangeli To: Hugh Dickins Cc: KOSAKI Motohiro , linux-mm@kvack.org, Linus Torvalds , Andrew Morton , linux-kernel@vger.kernel.org, Marcelo Tosatti , Adam Litke , Avi Kivity , Rik van Riel , Mel Gorman , Dave Hansen , Benjamin Herrenschmidt , Ingo Molnar , Mike Travis , KAMEZAWA Hiroyuki , Christoph Lameter , Chris Wright , bpicco@redhat.com, Balbir Singh , "Michael S. Tsirkin" , Peter Zijlstra , Johannes Weiner , Daisuke Nishimura , Chris Mason , Borislav Petkov Subject: Re: [PATCH 43 of 66] don't leave orhpaned swap cache after ksm merging Message-ID: <20101110160838.GK6809@random.random> References: <20101109120747.BC4B.A69D9226@jp.fujitsu.com> <20101109214036.GE6809@random.random> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 09, 2010 at 11:49:30PM -0800, Hugh Dickins wrote: > We did ask you back then to send in a fix separate from THP, but both > sides then forgot about it until recently. Correct :). > We didn't agree on what the fix should look like. You're keen to change > the page locking there, I didn't make a persuasive case for keeping it > as is, yet I can see no point whatever in changing it for this swap fix. > Could I persuade you to approve this simpler alternative? Sure your version will work fine too. I insisted in removing the page lock around replace_page because I didn't see the point of it and I like strict code, but keeping it can do no harm. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with SMTP id D0A006B004A for ; Wed, 10 Nov 2010 11:09:59 -0500 (EST) Date: Wed, 10 Nov 2010 17:08:38 +0100 From: Andrea Arcangeli Subject: Re: [PATCH 43 of 66] don't leave orhpaned swap cache after ksm merging Message-ID: <20101110160838.GK6809@random.random> References: <20101109120747.BC4B.A69D9226@jp.fujitsu.com> <20101109214036.GE6809@random.random> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org To: Hugh Dickins Cc: KOSAKI Motohiro , linux-mm@kvack.org, Linus Torvalds , Andrew Morton , linux-kernel@vger.kernel.org, Marcelo Tosatti , Adam Litke , Avi Kivity , Rik van Riel , Mel Gorman , Dave Hansen , Benjamin Herrenschmidt , Ingo Molnar , Mike Travis , KAMEZAWA Hiroyuki , Christoph Lameter , Chris Wright , bpicco@redhat.com, Balbir Singh , "Michael S. Tsirkin" , Peter Zijlstra , Johannes Weiner , Daisuke Nishimura , Chris Mason , Borislav Petkov List-ID: On Tue, Nov 09, 2010 at 11:49:30PM -0800, Hugh Dickins wrote: > We did ask you back then to send in a fix separate from THP, but both > sides then forgot about it until recently. Correct :). > We didn't agree on what the fix should look like. You're keen to change > the page locking there, I didn't make a persuasive case for keeping it > as is, yet I can see no point whatever in changing it for this swap fix. > Could I persuade you to approve this simpler alternative? Sure your version will work fine too. I insisted in removing the page lock around replace_page because I didn't see the point of it and I like strict code, but keeping it can do no harm. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org