From: Hugo Mills <hugo@carfax.org.uk>
To: Chris Samuel <chris@csamuel.org>
Cc: Li Zefan <lizf@cn.fujitsu.com>,
linux-btrfs@vger.kernel.org,
Goffredo Baroncelli <kreijack@libero.it>,
Chris Mason <chris.mason@oracle.com>,
liubo <liubo2009@cn.fujitsu.com>
Subject: Re: [PATCH v2 2/2] Cancel filesystem balance.
Date: Fri, 12 Nov 2010 11:36:55 +0000 [thread overview]
Message-ID: <20101112113655.GA2377@selene> (raw)
In-Reply-To: <4CDCC258.1050402@csamuel.org>
[-- Attachment #1: Type: text/plain, Size: 938 bytes --]
On Fri, Nov 12, 2010 at 03:28:08PM +1100, Chris Samuel wrote:
> On 12/11/10 12:33, Li Zefan wrote:
>
> > Is there any blocker that prevents us from canceling balance
> > by just Ctrl+C ?
>
> Given that there's been at least 1 report of it taking 12 hours
> to balance a non-trivial amount of data I suspect putting this
> operation into the background by default and having the cancel
> option might be a better plan.
Only 12 hours? Last time I tried it, it took 19. :)
It would certainly be easy enough to fork a copy of the userspace
tool to run the ioctl in the background. Probably a little more work
to make the balance a kernel thread. I'd prefer the former, for
ease of implementation.
Hugo.
--
=== Hugo Mills: hugo@... carfax.org.uk | darksatanic.net | lug.org.uk ===
PGP key: 515C238D from wwwkeys.eu.pgp.net or http://www.carfax.org.uk
--- Great oxymorons of the world, no. 3: Military Intelligence ---
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
next prev parent reply other threads:[~2010-11-12 11:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-12 0:36 [PATCH v2 0/2] Balance management, kernel side Hugo Mills
2010-11-09 22:43 ` [PATCH v2 1/2] Balance progress monitoring Hugo Mills
2010-11-09 22:52 ` [PATCH v2 2/2] Cancel filesystem balance Hugo Mills
2010-11-12 1:33 ` Li Zefan
2010-11-12 4:28 ` Chris Samuel
2010-11-12 8:08 ` Helmut Hullen
2010-11-12 9:07 ` Sander
2010-11-12 9:26 ` Andreas Philipp
2010-11-12 11:25 ` Helmut Hullen
2010-11-12 12:04 ` Sander
2010-11-12 11:36 ` Hugo Mills [this message]
2010-11-12 17:59 ` Hugo Mills
2011-03-20 8:52 ` [PATCH v2 0/2] Balance management, kernel side Andreas Philipp
2011-03-20 11:37 ` Hugo Mills
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101112113655.GA2377@selene \
--to=hugo@carfax.org.uk \
--cc=chris.mason@oracle.com \
--cc=chris@csamuel.org \
--cc=kreijack@libero.it \
--cc=linux-btrfs@vger.kernel.org \
--cc=liubo2009@cn.fujitsu.com \
--cc=lizf@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.