Hi Dave, After merging the final tree, today's linux-next build (powerpc ppc44x_defconfig) failed like this: net/ipv4/igmp.c: In function 'ip_mc_inc_group': net/ipv4/igmp.c:1228: error: implicit declaration of function 'for_each_pmc_rtnl' net/ipv4/igmp.c:1228: error: expected ';' before '{' token net/ipv4/igmp.c: In function 'ip_mc_unmap': net/ipv4/igmp.c:1333: error: expected ';' before 'igmp_group_dropped' net/ipv4/igmp.c: In function 'ip_mc_remap': net/ipv4/igmp.c:1343: error: expected ';' before 'igmp_group_added' net/ipv4/igmp.c: In function 'ip_mc_down': net/ipv4/igmp.c:1355: error: expected ';' before 'igmp_group_dropped' net/ipv4/igmp.c: In function 'ip_mc_up': net/ipv4/igmp.c:1400: error: expected ';' before 'igmp_group_added' net/ipv4/igmp.c: In function 'ip_mc_del_src': net/ipv4/igmp.c:1521: error: implicit declaration of function 'for_each_pmc_rcu' net/ipv4/igmp.c:1521: error: expected ';' before '{' token net/ipv4/igmp.c: In function 'ip_mc_add_src': net/ipv4/igmp.c:1693: error: expected ';' before '{' token net/ipv4/igmp.c: In function 'ip_mc_join_group': net/ipv4/igmp.c:1800: error: expected ';' before '{' token net/ipv4/igmp.c: In function 'ip_mc_source': net/ipv4/igmp.c:1938: error: expected ';' before '{' token net/ipv4/igmp.c: In function 'ip_mc_msfilter': net/ipv4/igmp.c:2081: error: expected ';' before '{' token net/ipv4/igmp.c: In function 'ip_mc_msfget': net/ipv4/igmp.c:2159: error: expected ';' before '{' token net/ipv4/igmp.c: In function 'ip_mc_gsfget': net/ipv4/igmp.c:2212: error: expected ';' before '{' token net/ipv4/igmp.c:2240: warning: label 'done' defined but not used net/ipv4/igmp.c: In function 'ip_mc_sf_allow': net/ipv4/igmp.c:2261: error: expected ';' before '{' token net/ipv4/igmp.c: In function 'ip_check_mc': net/ipv4/igmp.c:2326: error: expected ';' before '{' token net/ipv4/igmp.c:2322: warning: unused variable 'psf' Caused by commit 1d7138de878d1d4210727c1200193e69596f93b3 ("igmp: RCU conversion of in_dev->mc_list"). The for_each_pmc_rtnl and for_each_pmc_rcu definitions are protected by CONFIG_IP_MULTICAST, but the uses are not ... I have reverted that commit for today. -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/