From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josef Bacik Subject: Re: [PATCH 4/6] Ext4: fail if we try to use hole punch Date: Tue, 16 Nov 2010 07:50:16 -0500 Message-ID: <20101116125016.GA31957@dhcp231-156.rdu.redhat.com> References: <1289840723-3056-1-git-send-email-josef@redhat.com> <1289840723-3056-5-git-send-email-josef@redhat.com> <4CE2783F.1020004@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Josef Bacik , david@fromorbit.com, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com, cmm@us.ibm.com, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com To: Avi Kivity Return-path: In-Reply-To: <4CE2783F.1020004@redhat.com> List-ID: On Tue, Nov 16, 2010 at 02:25:35PM +0200, Avi Kivity wrote: > On 11/15/2010 07:05 PM, Josef Bacik wrote: >> Ext4 doesn't have the ability to punch holes yet, so make sure we return >> EOPNOTSUPP if we try to use hole punching through fallocate. This support can >> be added later. Thanks, >> > > Instead of teaching filesystems to fail if they don't support the > capability, why don't supporting filesystems say so, allowing the fail > code to be in common code? > There is no simple way to test if a filesystem supports hole punching or not so the check has to be done per fs. Thanks, Josef From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id oAGCnR1X047721 for ; Tue, 16 Nov 2010 06:49:27 -0600 Received: from mx1.redhat.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 1B5481C47913 for ; Tue, 16 Nov 2010 04:50:59 -0800 (PST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id 1LYDTVFzcGCFEAdE for ; Tue, 16 Nov 2010 04:50:59 -0800 (PST) Date: Tue, 16 Nov 2010 07:50:16 -0500 From: Josef Bacik Subject: Re: [PATCH 4/6] Ext4: fail if we try to use hole punch Message-ID: <20101116125016.GA31957@dhcp231-156.rdu.redhat.com> References: <1289840723-3056-1-git-send-email-josef@redhat.com> <1289840723-3056-5-git-send-email-josef@redhat.com> <4CE2783F.1020004@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4CE2783F.1020004@redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Avi Kivity Cc: ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org, xfs@oss.sgi.com, cluster-devel@redhat.com, cmm@us.ibm.com, Josef Bacik , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org On Tue, Nov 16, 2010 at 02:25:35PM +0200, Avi Kivity wrote: > On 11/15/2010 07:05 PM, Josef Bacik wrote: >> Ext4 doesn't have the ability to punch holes yet, so make sure we return >> EOPNOTSUPP if we try to use hole punching through fallocate. This support can >> be added later. Thanks, >> > > Instead of teaching filesystems to fail if they don't support the > capability, why don't supporting filesystems say so, allowing the fail > code to be in common code? > There is no simple way to test if a filesystem supports hole punching or not so the check has to be done per fs. Thanks, Josef _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josef Bacik Date: Tue, 16 Nov 2010 12:50:59 -0000 Subject: [Ocfs2-devel] [PATCH 4/6] Ext4: fail if we try to use hole punch In-Reply-To: <4CE2783F.1020004@redhat.com> References: <1289840723-3056-1-git-send-email-josef@redhat.com> <1289840723-3056-5-git-send-email-josef@redhat.com> <4CE2783F.1020004@redhat.com> Message-ID: <20101116125016.GA31957@dhcp231-156.rdu.redhat.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Avi Kivity Cc: Josef Bacik , david@fromorbit.com, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com, cmm@us.ibm.com, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com On Tue, Nov 16, 2010 at 02:25:35PM +0200, Avi Kivity wrote: > On 11/15/2010 07:05 PM, Josef Bacik wrote: >> Ext4 doesn't have the ability to punch holes yet, so make sure we return >> EOPNOTSUPP if we try to use hole punching through fallocate. This support can >> be added later. Thanks, >> > > Instead of teaching filesystems to fail if they don't support the > capability, why don't supporting filesystems say so, allowing the fail > code to be in common code? > There is no simple way to test if a filesystem supports hole punching or not so the check has to be done per fs. Thanks, Josef