From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josef Bacik Subject: Re: [PATCH 4/6] Ext4: fail if we try to use hole punch Date: Tue, 16 Nov 2010 11:33:21 -0500 Message-ID: <20101116163320.GB2524@localhost.localdomain> References: <1289840723-3056-1-git-send-email-josef@redhat.com> <1289840723-3056-5-git-send-email-josef@redhat.com> <4CE2AF5B.7020500@draigBrady.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Cc: Josef Bacik , david@fromorbit.com, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com, cmm@us.ibm.com, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com To: =?iso-8859-1?Q?P=E1draig?= Brady Return-path: In-Reply-To: <4CE2AF5B.7020500@draigBrady.com> List-ID: On Tue, Nov 16, 2010 at 04:20:43PM +0000, P=E1draig Brady wrote: > On 15/11/10 17:05, Josef Bacik wrote: > > Ext4 doesn't have the ability to punch holes yet, so make sure we r= eturn > > EOPNOTSUPP if we try to use hole punching through fallocate. This = support can > > be added later. Thanks, > >=20 > > Signed-off-by: Josef Bacik > > --- > > fs/ext4/extents.c | 4 ++++ > > 1 files changed, 4 insertions(+), 0 deletions(-) > >=20 > > diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c > > index 0554c48..35bca73 100644 > > --- a/fs/ext4/extents.c > > +++ b/fs/ext4/extents.c > > @@ -3622,6 +3622,10 @@ long ext4_fallocate(struct inode *inode, int= mode, loff_t offset, loff_t len) > > struct ext4_map_blocks map; > > unsigned int credits, blkbits =3D inode->i_blkbits; > > =20 > > + /* We only support the FALLOC_FL_KEEP_SIZE mode */ > > + if (mode && (mode !=3D FALLOC_FL_KEEP_SIZE)) > > + return -EOPNOTSUPP; > > + > > /* > > * currently supporting (pre)allocate mode for extent-based > > * files _only_ >=20 > So for older versions of ext4 or other filesystems, how do we know > that fallocate(...,FALLOC_FL_PUNCH_HOLE) is not supported. > I.E. how do we detect at runtime that the call succeeded > and didn't just do a normal fallocate()? > Older kernels won't accept FALLOC_FL_PUNCH_HOLE, so you'll get an error= =2E Thanks, Josef=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754942Ab0KPQdt (ORCPT ); Tue, 16 Nov 2010 11:33:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:12097 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754350Ab0KPQdr (ORCPT ); Tue, 16 Nov 2010 11:33:47 -0500 Date: Tue, 16 Nov 2010 11:33:21 -0500 From: Josef Bacik To: =?iso-8859-1?Q?P=E1draig?= Brady Cc: Josef Bacik , david@fromorbit.com, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com, cmm@us.ibm.com, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com Subject: Re: [PATCH 4/6] Ext4: fail if we try to use hole punch Message-ID: <20101116163320.GB2524@localhost.localdomain> References: <1289840723-3056-1-git-send-email-josef@redhat.com> <1289840723-3056-5-git-send-email-josef@redhat.com> <4CE2AF5B.7020500@draigBrady.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4CE2AF5B.7020500@draigBrady.com> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 16, 2010 at 04:20:43PM +0000, Pádraig Brady wrote: > On 15/11/10 17:05, Josef Bacik wrote: > > Ext4 doesn't have the ability to punch holes yet, so make sure we return > > EOPNOTSUPP if we try to use hole punching through fallocate. This support can > > be added later. Thanks, > > > > Signed-off-by: Josef Bacik > > --- > > fs/ext4/extents.c | 4 ++++ > > 1 files changed, 4 insertions(+), 0 deletions(-) > > > > diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c > > index 0554c48..35bca73 100644 > > --- a/fs/ext4/extents.c > > +++ b/fs/ext4/extents.c > > @@ -3622,6 +3622,10 @@ long ext4_fallocate(struct inode *inode, int mode, loff_t offset, loff_t len) > > struct ext4_map_blocks map; > > unsigned int credits, blkbits = inode->i_blkbits; > > > > + /* We only support the FALLOC_FL_KEEP_SIZE mode */ > > + if (mode && (mode != FALLOC_FL_KEEP_SIZE)) > > + return -EOPNOTSUPP; > > + > > /* > > * currently supporting (pre)allocate mode for extent-based > > * files _only_ > > So for older versions of ext4 or other filesystems, how do we know > that fallocate(...,FALLOC_FL_PUNCH_HOLE) is not supported. > I.E. how do we detect at runtime that the call succeeded > and didn't just do a normal fallocate()? > Older kernels won't accept FALLOC_FL_PUNCH_HOLE, so you'll get an error. Thanks, Josef From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id oAGGW48l085650 for ; Tue, 16 Nov 2010 10:32:05 -0600 Received: from mx1.redhat.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 0217F185480 for ; Tue, 16 Nov 2010 08:33:37 -0800 (PST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id jkDyyjmQCXyaPBwF for ; Tue, 16 Nov 2010 08:33:37 -0800 (PST) Date: Tue, 16 Nov 2010 11:33:21 -0500 From: Josef Bacik Subject: Re: [PATCH 4/6] Ext4: fail if we try to use hole punch Message-ID: <20101116163320.GB2524@localhost.localdomain> References: <1289840723-3056-1-git-send-email-josef@redhat.com> <1289840723-3056-5-git-send-email-josef@redhat.com> <4CE2AF5B.7020500@draigBrady.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4CE2AF5B.7020500@draigBrady.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: =?iso-8859-1?Q?P=E1draig?= Brady Cc: ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org, xfs@oss.sgi.com, cluster-devel@redhat.com, cmm@us.ibm.com, Josef Bacik , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org On Tue, Nov 16, 2010 at 04:20:43PM +0000, P=E1draig Brady wrote: > On 15/11/10 17:05, Josef Bacik wrote: > > Ext4 doesn't have the ability to punch holes yet, so make sure we return > > EOPNOTSUPP if we try to use hole punching through fallocate. This supp= ort can > > be added later. Thanks, > > = > > Signed-off-by: Josef Bacik > > --- > > fs/ext4/extents.c | 4 ++++ > > 1 files changed, 4 insertions(+), 0 deletions(-) > > = > > diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c > > index 0554c48..35bca73 100644 > > --- a/fs/ext4/extents.c > > +++ b/fs/ext4/extents.c > > @@ -3622,6 +3622,10 @@ long ext4_fallocate(struct inode *inode, int mod= e, loff_t offset, loff_t len) > > struct ext4_map_blocks map; > > unsigned int credits, blkbits =3D inode->i_blkbits; > > = > > + /* We only support the FALLOC_FL_KEEP_SIZE mode */ > > + if (mode && (mode !=3D FALLOC_FL_KEEP_SIZE)) > > + return -EOPNOTSUPP; > > + > > /* > > * currently supporting (pre)allocate mode for extent-based > > * files _only_ > = > So for older versions of ext4 or other filesystems, how do we know > that fallocate(...,FALLOC_FL_PUNCH_HOLE) is not supported. > I.E. how do we detect at runtime that the call succeeded > and didn't just do a normal fallocate()? > Older kernels won't accept FALLOC_FL_PUNCH_HOLE, so you'll get an error. Thanks, Josef = _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josef Bacik Date: Tue, 16 Nov 2010 16:33:37 -0000 Subject: [Ocfs2-devel] [PATCH 4/6] Ext4: fail if we try to use hole punch In-Reply-To: <4CE2AF5B.7020500@draigBrady.com> References: <1289840723-3056-1-git-send-email-josef@redhat.com> <1289840723-3056-5-git-send-email-josef@redhat.com> <4CE2AF5B.7020500@draigBrady.com> Message-ID: <20101116163320.GB2524@localhost.localdomain> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: =?iso-8859-1?Q?P=E1draig?= Brady Cc: Josef Bacik , david@fromorbit.com, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com, cmm@us.ibm.com, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com On Tue, Nov 16, 2010 at 04:20:43PM +0000, P?draig Brady wrote: > On 15/11/10 17:05, Josef Bacik wrote: > > Ext4 doesn't have the ability to punch holes yet, so make sure we return > > EOPNOTSUPP if we try to use hole punching through fallocate. This support can > > be added later. Thanks, > > > > Signed-off-by: Josef Bacik > > --- > > fs/ext4/extents.c | 4 ++++ > > 1 files changed, 4 insertions(+), 0 deletions(-) > > > > diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c > > index 0554c48..35bca73 100644 > > --- a/fs/ext4/extents.c > > +++ b/fs/ext4/extents.c > > @@ -3622,6 +3622,10 @@ long ext4_fallocate(struct inode *inode, int mode, loff_t offset, loff_t len) > > struct ext4_map_blocks map; > > unsigned int credits, blkbits = inode->i_blkbits; > > > > + /* We only support the FALLOC_FL_KEEP_SIZE mode */ > > + if (mode && (mode != FALLOC_FL_KEEP_SIZE)) > > + return -EOPNOTSUPP; > > + > > /* > > * currently supporting (pre)allocate mode for extent-based > > * files _only_ > > So for older versions of ext4 or other filesystems, how do we know > that fallocate(...,FALLOC_FL_PUNCH_HOLE) is not supported. > I.E. how do we detect at runtime that the call succeeded > and didn't just do a normal fallocate()? > Older kernels won't accept FALLOC_FL_PUNCH_HOLE, so you'll get an error. Thanks, Josef