From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757745Ab0KQBQG (ORCPT ); Tue, 16 Nov 2010 20:16:06 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:60789 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755375Ab0KQBQF (ORCPT ); Tue, 16 Nov 2010 20:16:05 -0500 Date: Tue, 16 Nov 2010 17:12:25 -0800 From: Andrew Morton To: Daisuke Nishimura Cc: Michal Hocko , linux-mm@kvack.org, KAMEZAWA Hiroyuki , linux-kernel@vger.kernel.org, balbir@linux.vnet.ibm.com, stable@kernel.org Subject: Re: [PATCH] Make swap accounting default behavior configurable Message-Id: <20101116171225.274019cf.akpm@linux-foundation.org> In-Reply-To: <20101117092339.1b7c2d6d.nishimura@mxp.nes.nec.co.jp> References: <20101116101726.GA21296@tiehlicka.suse.cz> <20101116124615.978ed940.akpm@linux-foundation.org> <20101117092339.1b7c2d6d.nishimura@mxp.nes.nec.co.jp> X-Mailer: Sylpheed 2.7.1 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 17 Nov 2010 09:23:39 +0900 Daisuke Nishimura wrote: > > > > > > diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt > > > index ed45e98..14eafa5 100644 > > > --- a/Documentation/kernel-parameters.txt > > > +++ b/Documentation/kernel-parameters.txt > > > @@ -2385,6 +2385,9 @@ and is between 256 and 4096 characters. It is defined in the file > > > improve throughput, but will also increase the > > > amount of memory reserved for use by the client. > > > > > > + swapaccount [KNL] Enable accounting of swap in memory resource > > > + controller. (See Documentation/cgroups/memory.txt) > > > > So we have swapaccount and noswapaccount. Ho hum, "swapaccount=[1|0]" > > would have been better. > > > I suggested to keep "noswapaccount" for compatibility. > If you and other guys don't like having two parameters, I don't stick to > the old parameter. > Yes, we're stuck with the old one now. But we should note that "foo=[0|1]" is superior to "foo" and "nofoo". Even if we didn't initially intend to add "nofoo". From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail202.messagelabs.com (mail202.messagelabs.com [216.82.254.227]) by kanga.kvack.org (Postfix) with ESMTP id E9E4B6B00F8 for ; Tue, 16 Nov 2010 20:15:55 -0500 (EST) Date: Tue, 16 Nov 2010 17:12:25 -0800 From: Andrew Morton Subject: Re: [PATCH] Make swap accounting default behavior configurable Message-Id: <20101116171225.274019cf.akpm@linux-foundation.org> In-Reply-To: <20101117092339.1b7c2d6d.nishimura@mxp.nes.nec.co.jp> References: <20101116101726.GA21296@tiehlicka.suse.cz> <20101116124615.978ed940.akpm@linux-foundation.org> <20101117092339.1b7c2d6d.nishimura@mxp.nes.nec.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Daisuke Nishimura Cc: Michal Hocko , linux-mm@kvack.org, KAMEZAWA Hiroyuki , linux-kernel@vger.kernel.org, balbir@linux.vnet.ibm.com, stable@kernel.org List-ID: On Wed, 17 Nov 2010 09:23:39 +0900 Daisuke Nishimura wrote: > > > > > > diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt > > > index ed45e98..14eafa5 100644 > > > --- a/Documentation/kernel-parameters.txt > > > +++ b/Documentation/kernel-parameters.txt > > > @@ -2385,6 +2385,9 @@ and is between 256 and 4096 characters. It is defined in the file > > > improve throughput, but will also increase the > > > amount of memory reserved for use by the client. > > > > > > + swapaccount [KNL] Enable accounting of swap in memory resource > > > + controller. (See Documentation/cgroups/memory.txt) > > > > So we have swapaccount and noswapaccount. Ho hum, "swapaccount=[1|0]" > > would have been better. > > > I suggested to keep "noswapaccount" for compatibility. > If you and other guys don't like having two parameters, I don't stick to > the old parameter. > Yes, we're stuck with the old one now. But we should note that "foo=[0|1]" is superior to "foo" and "nofoo". Even if we didn't initially intend to add "nofoo". -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org