From: Tony Lindgren <tony@atomide.com>
To: Tomi Valkeinen <tomi.valkeinen@nokia.com>
Cc: "ext Nilofer, Samreen" <samreen@ti.com>,
Grazvydas Ignotas <notasas@gmail.com>,
"Hiremath, Vaibhav" <hvaibhav@ti.com>,
"Quadros Roger (Nokia-MS/Helsinki)" <roger.quadros@nokia.com>,
"Guruswamy, Senthilvadivu" <svadivu@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>
Subject: Re: [PATCH v4] OMAP3: DSS: Kconfig changes to enable display
Date: Tue, 16 Nov 2010 19:38:43 +0000 [thread overview]
Message-ID: <20101116193843.GZ9264@atomide.com> (raw)
In-Reply-To: <1289915437.2668.107.camel@tubuntu>
* Tomi Valkeinen <tomi.valkeinen@nokia.com> [101116 05:41]:
> On Tue, 2010-11-16 at 07:09 +0100, ext Nilofer, Samreen wrote:
> > Hi,
> > Any more comments on this patch?
>
> I'm not sure if enabling kernel options by default is a good thing.
> Somehow I remember that enabling things by default is not looked kindly
> at. Shouldn't they be enabled in the arch/arm/configs config file, if
> they are wanted?
>
> Tony, do you have opinnion on this? Should DSS features be enabled by
> default in the Kconfig files, or only in the board config file?
The best thing would be to have DSS y if ARCH_OMAP2PLUS or similar,
then have all the features built in and pass the configuration options
in platform_data. That still allows disabling certain features with
Kconfig if needed for memory consumption etc. But the omap2plus_defconfig
should "just work" on all the boards.
Tony
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Tomi Valkeinen <tomi.valkeinen@nokia.com>
Cc: "ext Nilofer, Samreen" <samreen@ti.com>,
Grazvydas Ignotas <notasas@gmail.com>,
"Hiremath, Vaibhav" <hvaibhav@ti.com>,
"Quadros Roger (Nokia-MS/Helsinki)" <roger.quadros@nokia.com>,
"Guruswamy, Senthilvadivu" <svadivu@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>
Subject: Re: [PATCH v4] OMAP3: DSS: Kconfig changes to enable display options on OMAP3
Date: Tue, 16 Nov 2010 11:38:43 -0800 [thread overview]
Message-ID: <20101116193843.GZ9264@atomide.com> (raw)
In-Reply-To: <1289915437.2668.107.camel@tubuntu>
* Tomi Valkeinen <tomi.valkeinen@nokia.com> [101116 05:41]:
> On Tue, 2010-11-16 at 07:09 +0100, ext Nilofer, Samreen wrote:
> > Hi,
> > Any more comments on this patch?
>
> I'm not sure if enabling kernel options by default is a good thing.
> Somehow I remember that enabling things by default is not looked kindly
> at. Shouldn't they be enabled in the arch/arm/configs config file, if
> they are wanted?
>
> Tony, do you have opinnion on this? Should DSS features be enabled by
> default in the Kconfig files, or only in the board config file?
The best thing would be to have DSS y if ARCH_OMAP2PLUS or similar,
then have all the features built in and pass the configuration options
in platform_data. That still allows disabling certain features with
Kconfig if needed for memory consumption etc. But the omap2plus_defconfig
should "just work" on all the boards.
Tony
next prev parent reply other threads:[~2010-11-16 19:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 3:17 [PATCH v4] OMAP3: DSS: Kconfig changes to enable display options on OMAP3 Samreen
2010-10-26 3:29 ` Samreen
2010-11-16 6:09 ` Nilofer, Samreen
2010-11-16 6:21 ` [PATCH v4] OMAP3: DSS: Kconfig changes to enable display Nilofer, Samreen
2010-11-16 13:50 ` Tomi Valkeinen
2010-11-16 13:50 ` [PATCH v4] OMAP3: DSS: Kconfig changes to enable display options on OMAP3 Tomi Valkeinen
2010-11-16 19:38 ` Tony Lindgren [this message]
2010-11-16 19:38 ` Tony Lindgren
2010-11-16 19:55 ` Kevin Hilman
2010-11-16 19:55 ` Kevin Hilman
2010-11-16 20:10 ` [PATCH v4] OMAP3: DSS: Kconfig changes to enable display Tony Lindgren
2010-11-16 20:10 ` [PATCH v4] OMAP3: DSS: Kconfig changes to enable display options on OMAP3 Tony Lindgren
2010-11-17 12:28 ` [PATCH v4] OMAP3: DSS: Kconfig changes to enable display Tomi Valkeinen
2010-11-17 12:28 ` [PATCH v4] OMAP3: DSS: Kconfig changes to enable display options on OMAP3 Tomi Valkeinen
2010-11-18 6:18 ` Paul Mundt
2010-11-18 6:18 ` Paul Mundt
2010-11-18 16:44 ` [PATCH v4] OMAP3: DSS: Kconfig changes to enable display Tony Lindgren
2010-11-18 16:44 ` [PATCH v4] OMAP3: DSS: Kconfig changes to enable display options on OMAP3 Tony Lindgren
2010-11-18 18:38 ` Paul Mundt
2010-11-18 18:38 ` Paul Mundt
2010-11-18 19:10 ` [PATCH v4] OMAP3: DSS: Kconfig changes to enable display Tony Lindgren
2010-11-18 19:10 ` [PATCH v4] OMAP3: DSS: Kconfig changes to enable display options on OMAP3 Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101116193843.GZ9264@atomide.com \
--to=tony@atomide.com \
--cc=hvaibhav@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=notasas@gmail.com \
--cc=roger.quadros@nokia.com \
--cc=samreen@ti.com \
--cc=svadivu@ti.com \
--cc=tomi.valkeinen@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.