From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Date: Tue, 16 Nov 2010 19:38:43 +0000 Subject: Re: [PATCH v4] OMAP3: DSS: Kconfig changes to enable display Message-Id: <20101116193843.GZ9264@atomide.com> List-Id: References: <1288063074-8879-1-git-send-email-samreen@ti.com> <1289915437.2668.107.camel@tubuntu> In-Reply-To: <1289915437.2668.107.camel@tubuntu> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tomi Valkeinen Cc: "ext Nilofer, Samreen" , Grazvydas Ignotas , "Hiremath, Vaibhav" , "Quadros Roger (Nokia-MS/Helsinki)" , "Guruswamy, Senthilvadivu" , "linux-omap@vger.kernel.org" , "linux-fbdev@vger.kernel.org" * Tomi Valkeinen [101116 05:41]: > On Tue, 2010-11-16 at 07:09 +0100, ext Nilofer, Samreen wrote: > > Hi, > > Any more comments on this patch? > > I'm not sure if enabling kernel options by default is a good thing. > Somehow I remember that enabling things by default is not looked kindly > at. Shouldn't they be enabled in the arch/arm/configs config file, if > they are wanted? > > Tony, do you have opinnion on this? Should DSS features be enabled by > default in the Kconfig files, or only in the board config file? The best thing would be to have DSS y if ARCH_OMAP2PLUS or similar, then have all the features built in and pass the configuration options in platform_data. That still allows disabling certain features with Kconfig if needed for memory consumption etc. But the omap2plus_defconfig should "just work" on all the boards. Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v4] OMAP3: DSS: Kconfig changes to enable display options on OMAP3 Date: Tue, 16 Nov 2010 11:38:43 -0800 Message-ID: <20101116193843.GZ9264@atomide.com> References: <1288063074-8879-1-git-send-email-samreen@ti.com> <1289915437.2668.107.camel@tubuntu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:17247 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756145Ab0KPTiz (ORCPT ); Tue, 16 Nov 2010 14:38:55 -0500 Content-Disposition: inline In-Reply-To: <1289915437.2668.107.camel@tubuntu> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Tomi Valkeinen Cc: "ext Nilofer, Samreen" , Grazvydas Ignotas , "Hiremath, Vaibhav" , "Quadros Roger (Nokia-MS/Helsinki)" , "Guruswamy, Senthilvadivu" , "linux-omap@vger.kernel.org" , "linux-fbdev@vger.kernel.org" * Tomi Valkeinen [101116 05:41]: > On Tue, 2010-11-16 at 07:09 +0100, ext Nilofer, Samreen wrote: > > Hi, > > Any more comments on this patch? > > I'm not sure if enabling kernel options by default is a good thing. > Somehow I remember that enabling things by default is not looked kindly > at. Shouldn't they be enabled in the arch/arm/configs config file, if > they are wanted? > > Tony, do you have opinnion on this? Should DSS features be enabled by > default in the Kconfig files, or only in the board config file? The best thing would be to have DSS y if ARCH_OMAP2PLUS or similar, then have all the features built in and pass the configuration options in platform_data. That still allows disabling certain features with Kconfig if needed for memory consumption etc. But the omap2plus_defconfig should "just work" on all the boards. Tony