From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758839Ab0KPVWZ (ORCPT ); Tue, 16 Nov 2010 16:22:25 -0500 Received: from kroah.org ([198.145.64.141]:50195 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755170Ab0KPVWY (ORCPT ); Tue, 16 Nov 2010 16:22:24 -0500 Date: Tue, 16 Nov 2010 13:21:57 -0800 From: Greg KH To: Andrew Morton Cc: Michal Hocko , Daisuke Nishimura , linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@kernel.org, KAMEZAWA Hiroyuki , balbir@linux.vnet.ibm.com Subject: Re: [stable] [PATCH] Make swap accounting default behavior configurable Message-ID: <20101116212157.GB9359@kroah.com> References: <20101116101726.GA21296@tiehlicka.suse.cz> <20101116124615.978ed940.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101116124615.978ed940.akpm@linux-foundation.org> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 16, 2010 at 12:46:15PM -0800, Andrew Morton wrote: > On Tue, 16 Nov 2010 11:17:26 +0100 > Michal Hocko wrote: > > > Hi Andrew, > > could you consider the following patch for the Linus tree, please? > > The discussion took place in this email thread > > http://lkml.org/lkml/2010/11/10/114. > > The patch is based on top of 151f52f09c572 commit in the Linus tree. > > > > Please let me know if there I should route this patch through somebody > > else. > > > > Thanks! > > > > --- > > >From 30238aaec758988493af793939f14b0ba83dc4b3 Mon Sep 17 00:00:00 2001 > > From: Michal Hocko > > Date: Wed, 10 Nov 2010 13:30:04 +0100 > > Subject: [PATCH] Make swap accounting default behavior configurable > > > > Swap accounting can be configured by CONFIG_CGROUP_MEM_RES_CTLR_SWAP > > configuration option and then it is turned on by default. There is > > a boot option (noswapaccount) which can disable this feature. > > > > This makes it hard for distributors to enable the configuration option > > as this feature leads to a bigger memory consumption and this is a no-go > > for general purpose distribution kernel. On the other hand swap > > accounting may be very usuful for some workloads. > > This patch is needed by distros, and distros use the -stable tree, I > assume. Do you see reasons why this patch should be backported into > -stable, so distros don't need to patch it themselves? If so, any > particular kernel versions? 2.6.37? Sorry, I really don't want to start backporting features to stable kernels if at all possible. Distros can pick them up on their own if they determine it is needed. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with ESMTP id 5B63C6B0085 for ; Tue, 16 Nov 2010 16:22:27 -0500 (EST) Date: Tue, 16 Nov 2010 13:21:57 -0800 From: Greg KH Subject: Re: [stable] [PATCH] Make swap accounting default behavior configurable Message-ID: <20101116212157.GB9359@kroah.com> References: <20101116101726.GA21296@tiehlicka.suse.cz> <20101116124615.978ed940.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101116124615.978ed940.akpm@linux-foundation.org> Sender: owner-linux-mm@kvack.org To: Andrew Morton Cc: Michal Hocko , Daisuke Nishimura , linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@kernel.org, KAMEZAWA Hiroyuki , balbir@linux.vnet.ibm.com List-ID: On Tue, Nov 16, 2010 at 12:46:15PM -0800, Andrew Morton wrote: > On Tue, 16 Nov 2010 11:17:26 +0100 > Michal Hocko wrote: > > > Hi Andrew, > > could you consider the following patch for the Linus tree, please? > > The discussion took place in this email thread > > http://lkml.org/lkml/2010/11/10/114. > > The patch is based on top of 151f52f09c572 commit in the Linus tree. > > > > Please let me know if there I should route this patch through somebody > > else. > > > > Thanks! > > > > --- > > >From 30238aaec758988493af793939f14b0ba83dc4b3 Mon Sep 17 00:00:00 2001 > > From: Michal Hocko > > Date: Wed, 10 Nov 2010 13:30:04 +0100 > > Subject: [PATCH] Make swap accounting default behavior configurable > > > > Swap accounting can be configured by CONFIG_CGROUP_MEM_RES_CTLR_SWAP > > configuration option and then it is turned on by default. There is > > a boot option (noswapaccount) which can disable this feature. > > > > This makes it hard for distributors to enable the configuration option > > as this feature leads to a bigger memory consumption and this is a no-go > > for general purpose distribution kernel. On the other hand swap > > accounting may be very usuful for some workloads. > > This patch is needed by distros, and distros use the -stable tree, I > assume. Do you see reasons why this patch should be backported into > -stable, so distros don't need to patch it themselves? If so, any > particular kernel versions? 2.6.37? Sorry, I really don't want to start backporting features to stable kernels if at all possible. Distros can pick them up on their own if they determine it is needed. thanks, greg k-h -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org