From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935080Ab0KQRdI (ORCPT ); Wed, 17 Nov 2010 12:33:08 -0500 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:47904 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934828Ab0KQRdG (ORCPT ); Wed, 17 Nov 2010 12:33:06 -0500 Date: Wed, 17 Nov 2010 17:32:49 +0000 From: Russell King - ARM Linux To: Catalin Marinas Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 05/20] ARM: LPAE: Introduce L_PTE_NOEXEC and L_PTE_NOWRITE Message-ID: <20101117173248.GG5308@n2100.arm.linux.org.uk> References: <1289584840-18097-1-git-send-email-catalin.marinas@arm.com> <1289584840-18097-6-git-send-email-catalin.marinas@arm.com> <20101115183014.GD31421@n2100.arm.linux.org.uk> <20101117171613.GB5308@n2100.arm.linux.org.uk> <20101117172425.GE5308@n2100.arm.linux.org.uk> <1290015033.2351.69.camel@e102109-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1290015033.2351.69.camel@e102109-lin.cambridge.arm.com> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 17, 2010 at 05:30:33PM +0000, Catalin Marinas wrote: > On Wed, 2010-11-17 at 17:24 +0000, Russell King - ARM Linux wrote: > > On Wed, Nov 17, 2010 at 05:22:12PM +0000, Catalin Marinas wrote: > > > Ah, good point, that was the mask. > > > > > > So for dmacoherent we make sure that L_PTE_EXEC is cleared. I suspect > > > we should now make sure that L_PTE_NOEXEC is set. For the other two, > > > just leave them as they are. > > > > Already done: > > > > #define pgprot_dmacoherent(prot) \ > > - __pgprot_modify(prot, L_PTE_MT_MASK|L_PTE_EXEC, L_PTE_MT_BUFFERABLE) > > + __pgprot_modify(prot, L_PTE_MT_MASK, L_PTE_MT_BUFFERABLE|L_PTE_XN) > > ... > > #define pgprot_dmacoherent(prot) \ > > - __pgprot_modify(prot, L_PTE_MT_MASK|L_PTE_EXEC, L_PTE_MT_UNCACHED) > > + __pgprot_modify(prot, L_PTE_MT_MASK, L_PTE_MT_UNCACHED|L_PTE_XN) > > Are you already doing such changes? Just to avoid duplicating effort > (and use common naming scheme). I did say that I had patches for all the issues I raised so far... They're just in the process of being posted (if lists.infradead.org this time can cope with one patch every 20 secs...) From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@arm.linux.org.uk (Russell King - ARM Linux) Date: Wed, 17 Nov 2010 17:32:49 +0000 Subject: [PATCH v2 05/20] ARM: LPAE: Introduce L_PTE_NOEXEC and L_PTE_NOWRITE In-Reply-To: <1290015033.2351.69.camel@e102109-lin.cambridge.arm.com> References: <1289584840-18097-1-git-send-email-catalin.marinas@arm.com> <1289584840-18097-6-git-send-email-catalin.marinas@arm.com> <20101115183014.GD31421@n2100.arm.linux.org.uk> <20101117171613.GB5308@n2100.arm.linux.org.uk> <20101117172425.GE5308@n2100.arm.linux.org.uk> <1290015033.2351.69.camel@e102109-lin.cambridge.arm.com> Message-ID: <20101117173248.GG5308@n2100.arm.linux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Nov 17, 2010 at 05:30:33PM +0000, Catalin Marinas wrote: > On Wed, 2010-11-17 at 17:24 +0000, Russell King - ARM Linux wrote: > > On Wed, Nov 17, 2010 at 05:22:12PM +0000, Catalin Marinas wrote: > > > Ah, good point, that was the mask. > > > > > > So for dmacoherent we make sure that L_PTE_EXEC is cleared. I suspect > > > we should now make sure that L_PTE_NOEXEC is set. For the other two, > > > just leave them as they are. > > > > Already done: > > > > #define pgprot_dmacoherent(prot) \ > > - __pgprot_modify(prot, L_PTE_MT_MASK|L_PTE_EXEC, L_PTE_MT_BUFFERABLE) > > + __pgprot_modify(prot, L_PTE_MT_MASK, L_PTE_MT_BUFFERABLE|L_PTE_XN) > > ... > > #define pgprot_dmacoherent(prot) \ > > - __pgprot_modify(prot, L_PTE_MT_MASK|L_PTE_EXEC, L_PTE_MT_UNCACHED) > > + __pgprot_modify(prot, L_PTE_MT_MASK, L_PTE_MT_UNCACHED|L_PTE_XN) > > Are you already doing such changes? Just to avoid duplicating effort > (and use common naming scheme). I did say that I had patches for all the issues I raised so far... They're just in the process of being posted (if lists.infradead.org this time can cope with one patch every 20 secs...)