From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joel Becker Subject: Re: [PATCH 3/6] Ocfs2: handle hole punching via fallocate properly Date: Wed, 17 Nov 2010 15:27:45 -0800 Message-ID: <20101117232745.GG25677@mail.oracle.com> References: <1289840723-3056-1-git-send-email-josef@redhat.com> <1289840723-3056-4-git-send-email-josef@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: david@fromorbit.com, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com, cmm@us.ibm.com, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com To: Josef Bacik Return-path: In-Reply-To: <1289840723-3056-4-git-send-email-josef@redhat.com> List-ID: On Mon, Nov 15, 2010 at 12:05:20PM -0500, Josef Bacik wrote: > This patch just makes ocfs2 use its UNRESERVP ioctl when we get the hole punch > flag in fallocate. I didn't test it, but it seems simple enough. Thanks, > > Signed-off-by: Josef Bacik Seems reasonable to me. Acked-by: Joel Becker Joel > --- > fs/ocfs2/file.c | 10 ++++++++-- > 1 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c > index 77b4c04..181ae52 100644 > --- a/fs/ocfs2/file.c > +++ b/fs/ocfs2/file.c > @@ -1992,6 +1992,7 @@ static long ocfs2_fallocate(struct inode *inode, int mode, loff_t offset, > struct ocfs2_super *osb = OCFS2_SB(inode->i_sb); > struct ocfs2_space_resv sr; > int change_size = 1; > + int cmd = OCFS2_IOC_RESVSP64; > > if (!ocfs2_writes_unwritten_extents(osb)) > return -EOPNOTSUPP; > @@ -2002,12 +2003,17 @@ static long ocfs2_fallocate(struct inode *inode, int mode, loff_t offset, > if (mode & FALLOC_FL_KEEP_SIZE) > change_size = 0; > > + if (mode & FALLOC_FL_PUNCH_HOLE) { > + cmd = OCFS2_IOC_UNRESVSP64; > + change_size = 0; > + } > + > sr.l_whence = 0; > sr.l_start = (s64)offset; > sr.l_len = (s64)len; > > - return __ocfs2_change_file_space(NULL, inode, offset, > - OCFS2_IOC_RESVSP64, &sr, change_size); > + return __ocfs2_change_file_space(NULL, inode, offset, cmd, &sr, > + change_size); > } > > int ocfs2_check_range_for_refcount(struct inode *inode, loff_t pos, > -- > 1.6.6.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- "Born under a bad sign. I been down since I began to crawl. If it wasn't for bad luck, I wouldn't have no luck at all." Joel Becker Senior Development Manager Oracle E-mail: joel.becker@oracle.com Phone: (650) 506-8127 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id oAHNR4kY110397 for ; Wed, 17 Nov 2010 17:27:06 -0600 Received: from rcsinet10.oracle.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 3E91613B5418 for ; Wed, 17 Nov 2010 15:28:37 -0800 (PST) Received: from rcsinet10.oracle.com (rcsinet10.oracle.com [148.87.113.121]) by cuda.sgi.com with ESMTP id 5v7B9Kk0pBZSQr4U for ; Wed, 17 Nov 2010 15:28:37 -0800 (PST) Date: Wed, 17 Nov 2010 15:27:45 -0800 From: Joel Becker Subject: Re: [PATCH 3/6] Ocfs2: handle hole punching via fallocate properly Message-ID: <20101117232745.GG25677@mail.oracle.com> References: <1289840723-3056-1-git-send-email-josef@redhat.com> <1289840723-3056-4-git-send-email-josef@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1289840723-3056-4-git-send-email-josef@redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Josef Bacik Cc: linux-kernel@vger.kernel.org, xfs@oss.sgi.com, cluster-devel@redhat.com, cmm@us.ibm.com, ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org On Mon, Nov 15, 2010 at 12:05:20PM -0500, Josef Bacik wrote: > This patch just makes ocfs2 use its UNRESERVP ioctl when we get the hole punch > flag in fallocate. I didn't test it, but it seems simple enough. Thanks, > > Signed-off-by: Josef Bacik Seems reasonable to me. Acked-by: Joel Becker Joel > --- > fs/ocfs2/file.c | 10 ++++++++-- > 1 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c > index 77b4c04..181ae52 100644 > --- a/fs/ocfs2/file.c > +++ b/fs/ocfs2/file.c > @@ -1992,6 +1992,7 @@ static long ocfs2_fallocate(struct inode *inode, int mode, loff_t offset, > struct ocfs2_super *osb = OCFS2_SB(inode->i_sb); > struct ocfs2_space_resv sr; > int change_size = 1; > + int cmd = OCFS2_IOC_RESVSP64; > > if (!ocfs2_writes_unwritten_extents(osb)) > return -EOPNOTSUPP; > @@ -2002,12 +2003,17 @@ static long ocfs2_fallocate(struct inode *inode, int mode, loff_t offset, > if (mode & FALLOC_FL_KEEP_SIZE) > change_size = 0; > > + if (mode & FALLOC_FL_PUNCH_HOLE) { > + cmd = OCFS2_IOC_UNRESVSP64; > + change_size = 0; > + } > + > sr.l_whence = 0; > sr.l_start = (s64)offset; > sr.l_len = (s64)len; > > - return __ocfs2_change_file_space(NULL, inode, offset, > - OCFS2_IOC_RESVSP64, &sr, change_size); > + return __ocfs2_change_file_space(NULL, inode, offset, cmd, &sr, > + change_size); > } > > int ocfs2_check_range_for_refcount(struct inode *inode, loff_t pos, > -- > 1.6.6.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- "Born under a bad sign. I been down since I began to crawl. If it wasn't for bad luck, I wouldn't have no luck at all." Joel Becker Senior Development Manager Oracle E-mail: joel.becker@oracle.com Phone: (650) 506-8127 _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joel Becker Date: Wed, 17 Nov 2010 23:28:26 -0000 Subject: [Ocfs2-devel] [PATCH 3/6] Ocfs2: handle hole punching via fallocate properly In-Reply-To: <1289840723-3056-4-git-send-email-josef@redhat.com> References: <1289840723-3056-1-git-send-email-josef@redhat.com> <1289840723-3056-4-git-send-email-josef@redhat.com> Message-ID: <20101117232745.GG25677@mail.oracle.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Josef Bacik Cc: david@fromorbit.com, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com, cmm@us.ibm.com, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com On Mon, Nov 15, 2010 at 12:05:20PM -0500, Josef Bacik wrote: > This patch just makes ocfs2 use its UNRESERVP ioctl when we get the hole punch > flag in fallocate. I didn't test it, but it seems simple enough. Thanks, > > Signed-off-by: Josef Bacik Seems reasonable to me. Acked-by: Joel Becker Joel > --- > fs/ocfs2/file.c | 10 ++++++++-- > 1 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c > index 77b4c04..181ae52 100644 > --- a/fs/ocfs2/file.c > +++ b/fs/ocfs2/file.c > @@ -1992,6 +1992,7 @@ static long ocfs2_fallocate(struct inode *inode, int mode, loff_t offset, > struct ocfs2_super *osb = OCFS2_SB(inode->i_sb); > struct ocfs2_space_resv sr; > int change_size = 1; > + int cmd = OCFS2_IOC_RESVSP64; > > if (!ocfs2_writes_unwritten_extents(osb)) > return -EOPNOTSUPP; > @@ -2002,12 +2003,17 @@ static long ocfs2_fallocate(struct inode *inode, int mode, loff_t offset, > if (mode & FALLOC_FL_KEEP_SIZE) > change_size = 0; > > + if (mode & FALLOC_FL_PUNCH_HOLE) { > + cmd = OCFS2_IOC_UNRESVSP64; > + change_size = 0; > + } > + > sr.l_whence = 0; > sr.l_start = (s64)offset; > sr.l_len = (s64)len; > > - return __ocfs2_change_file_space(NULL, inode, offset, > - OCFS2_IOC_RESVSP64, &sr, change_size); > + return __ocfs2_change_file_space(NULL, inode, offset, cmd, &sr, > + change_size); > } > > int ocfs2_check_range_for_refcount(struct inode *inode, loff_t pos, > -- > 1.6.6.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- "Born under a bad sign. I been down since I began to crawl. If it wasn't for bad luck, I wouldn't have no luck at all." Joel Becker Senior Development Manager Oracle E-mail: joel.becker at oracle.com Phone: (650) 506-8127 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joel Becker Date: Wed, 17 Nov 2010 15:27:45 -0800 Subject: [Cluster-devel] [PATCH 3/6] Ocfs2: handle hole punching via fallocate properly In-Reply-To: <1289840723-3056-4-git-send-email-josef@redhat.com> References: <1289840723-3056-1-git-send-email-josef@redhat.com> <1289840723-3056-4-git-send-email-josef@redhat.com> Message-ID: <20101117232745.GG25677@mail.oracle.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Nov 15, 2010 at 12:05:20PM -0500, Josef Bacik wrote: > This patch just makes ocfs2 use its UNRESERVP ioctl when we get the hole punch > flag in fallocate. I didn't test it, but it seems simple enough. Thanks, > > Signed-off-by: Josef Bacik Seems reasonable to me. Acked-by: Joel Becker Joel > --- > fs/ocfs2/file.c | 10 ++++++++-- > 1 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c > index 77b4c04..181ae52 100644 > --- a/fs/ocfs2/file.c > +++ b/fs/ocfs2/file.c > @@ -1992,6 +1992,7 @@ static long ocfs2_fallocate(struct inode *inode, int mode, loff_t offset, > struct ocfs2_super *osb = OCFS2_SB(inode->i_sb); > struct ocfs2_space_resv sr; > int change_size = 1; > + int cmd = OCFS2_IOC_RESVSP64; > > if (!ocfs2_writes_unwritten_extents(osb)) > return -EOPNOTSUPP; > @@ -2002,12 +2003,17 @@ static long ocfs2_fallocate(struct inode *inode, int mode, loff_t offset, > if (mode & FALLOC_FL_KEEP_SIZE) > change_size = 0; > > + if (mode & FALLOC_FL_PUNCH_HOLE) { > + cmd = OCFS2_IOC_UNRESVSP64; > + change_size = 0; > + } > + > sr.l_whence = 0; > sr.l_start = (s64)offset; > sr.l_len = (s64)len; > > - return __ocfs2_change_file_space(NULL, inode, offset, > - OCFS2_IOC_RESVSP64, &sr, change_size); > + return __ocfs2_change_file_space(NULL, inode, offset, cmd, &sr, > + change_size); > } > > int ocfs2_check_range_for_refcount(struct inode *inode, loff_t pos, > -- > 1.6.6.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- "Born under a bad sign. I been down since I began to crawl. If it wasn't for bad luck, I wouldn't have no luck at all." Joel Becker Senior Development Manager Oracle E-mail: joel.becker at oracle.com Phone: (650) 506-8127