From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932124Ab0KRQGa (ORCPT ); Thu, 18 Nov 2010 11:06:30 -0500 Received: from gir.skynet.ie ([193.1.99.77]:55319 "EHLO gir.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759329Ab0KRQG3 (ORCPT ); Thu, 18 Nov 2010 11:06:29 -0500 Date: Thu, 18 Nov 2010 16:06:13 +0000 From: Mel Gorman To: Andrea Arcangeli Cc: linux-mm@kvack.org, Linus Torvalds , Andrew Morton , linux-kernel@vger.kernel.org, Marcelo Tosatti , Adam Litke , Avi Kivity , Hugh Dickins , Rik van Riel , Dave Hansen , Benjamin Herrenschmidt , Ingo Molnar , Mike Travis , KAMEZAWA Hiroyuki , Christoph Lameter , Chris Wright , bpicco@redhat.com, KOSAKI Motohiro , Balbir Singh , "Michael S. Tsirkin" , Peter Zijlstra , Johannes Weiner , Daisuke Nishimura , Chris Mason , Borislav Petkov Subject: Re: [PATCH 44 of 66] skip transhuge pages in ksm for now Message-ID: <20101118160613.GZ8135@csn.ul.ie> References: <91ac2384163d0f01633e.1288798099@v2.random> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <91ac2384163d0f01633e.1288798099@v2.random> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 03, 2010 at 04:28:19PM +0100, Andrea Arcangeli wrote: > From: Andrea Arcangeli > > Skip transhuge pages in ksm for now. > > Signed-off-by: Andrea Arcangeli > Reviewed-by: Rik van Riel Acked-by: Mel Gorman This is an idle concern that I haven't looked into but is there any conflict between khugepaged scanning the KSM scanning? Specifically, I *think* the impact of this patch is that KSM will not accidentally split a huge page. Is that right? If so, it could do with being included in the changelog. On the other hand, can khugepaged be prevented from promoting a hugepage because of KSM? -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with ESMTP id 2AF096B004A for ; Thu, 18 Nov 2010 11:06:41 -0500 (EST) Date: Thu, 18 Nov 2010 16:06:13 +0000 From: Mel Gorman Subject: Re: [PATCH 44 of 66] skip transhuge pages in ksm for now Message-ID: <20101118160613.GZ8135@csn.ul.ie> References: <91ac2384163d0f01633e.1288798099@v2.random> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <91ac2384163d0f01633e.1288798099@v2.random> Sender: owner-linux-mm@kvack.org To: Andrea Arcangeli Cc: linux-mm@kvack.org, Linus Torvalds , Andrew Morton , linux-kernel@vger.kernel.org, Marcelo Tosatti , Adam Litke , Avi Kivity , Hugh Dickins , Rik van Riel , Dave Hansen , Benjamin Herrenschmidt , Ingo Molnar , Mike Travis , KAMEZAWA Hiroyuki , Christoph Lameter , Chris Wright , bpicco@redhat.com, KOSAKI Motohiro , Balbir Singh , "Michael S. Tsirkin" , Peter Zijlstra , Johannes Weiner , Daisuke Nishimura , Chris Mason , Borislav Petkov List-ID: On Wed, Nov 03, 2010 at 04:28:19PM +0100, Andrea Arcangeli wrote: > From: Andrea Arcangeli > > Skip transhuge pages in ksm for now. > > Signed-off-by: Andrea Arcangeli > Reviewed-by: Rik van Riel Acked-by: Mel Gorman This is an idle concern that I haven't looked into but is there any conflict between khugepaged scanning the KSM scanning? Specifically, I *think* the impact of this patch is that KSM will not accidentally split a huge page. Is that right? If so, it could do with being included in the changelog. On the other hand, can khugepaged be prevented from promoting a hugepage because of KSM? -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org