From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759604Ab0KRQR5 (ORCPT ); Thu, 18 Nov 2010 11:17:57 -0500 Received: from gir.skynet.ie ([193.1.99.77]:39619 "EHLO gir.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754722Ab0KRQRz (ORCPT ); Thu, 18 Nov 2010 11:17:55 -0500 Date: Thu, 18 Nov 2010 16:17:41 +0000 From: Mel Gorman To: Andrea Arcangeli Cc: linux-mm@kvack.org, Linus Torvalds , Andrew Morton , linux-kernel@vger.kernel.org, Marcelo Tosatti , Adam Litke , Avi Kivity , Hugh Dickins , Rik van Riel , Dave Hansen , Benjamin Herrenschmidt , Ingo Molnar , Mike Travis , KAMEZAWA Hiroyuki , Christoph Lameter , Chris Wright , bpicco@redhat.com, KOSAKI Motohiro , Balbir Singh , "Michael S. Tsirkin" , Peter Zijlstra , Johannes Weiner , Daisuke Nishimura , Chris Mason , Borislav Petkov Subject: Re: [PATCH 52 of 66] enable direct defrag Message-ID: <20101118161740.GC8135@csn.ul.ie> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 03, 2010 at 04:28:27PM +0100, Andrea Arcangeli wrote: > From: Andrea Arcangeli > > With memory compaction in, and lumpy-reclaim removed, it seems safe enough to > defrag memory during the (synchronous) transparent hugepage page faults > (TRANSPARENT_HUGEPAGE_DEFRAG_FLAG) and not only during khugepaged (async) > hugepage allocations that was already enabled even before memory compaction was > in (TRANSPARENT_HUGEPAGE_DEFRAG_KHUGEPAGED_FLAG). > While I'm hoping that my series on using compaction will be used instead of outright deletion of lumpy reclaim, this patch would still make sense. Acked-by: Mel Gorman > Signed-off-by: Andrea Arcangeli > --- > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -28,6 +28,7 @@ > */ > unsigned long transparent_hugepage_flags __read_mostly = > (1< + (1< (1< > /* default scan 8*512 pte (or vmas) every 30 second */ > -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with ESMTP id DE0E96B0087 for ; Thu, 18 Nov 2010 11:17:58 -0500 (EST) Date: Thu, 18 Nov 2010 16:17:41 +0000 From: Mel Gorman Subject: Re: [PATCH 52 of 66] enable direct defrag Message-ID: <20101118161740.GC8135@csn.ul.ie> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org To: Andrea Arcangeli Cc: linux-mm@kvack.org, Linus Torvalds , Andrew Morton , linux-kernel@vger.kernel.org, Marcelo Tosatti , Adam Litke , Avi Kivity , Hugh Dickins , Rik van Riel , Dave Hansen , Benjamin Herrenschmidt , Ingo Molnar , Mike Travis , KAMEZAWA Hiroyuki , Christoph Lameter , Chris Wright , bpicco@redhat.com, KOSAKI Motohiro , Balbir Singh , "Michael S. Tsirkin" , Peter Zijlstra , Johannes Weiner , Daisuke Nishimura , Chris Mason , Borislav Petkov List-ID: On Wed, Nov 03, 2010 at 04:28:27PM +0100, Andrea Arcangeli wrote: > From: Andrea Arcangeli > > With memory compaction in, and lumpy-reclaim removed, it seems safe enough to > defrag memory during the (synchronous) transparent hugepage page faults > (TRANSPARENT_HUGEPAGE_DEFRAG_FLAG) and not only during khugepaged (async) > hugepage allocations that was already enabled even before memory compaction was > in (TRANSPARENT_HUGEPAGE_DEFRAG_KHUGEPAGED_FLAG). > While I'm hoping that my series on using compaction will be used instead of outright deletion of lumpy reclaim, this patch would still make sense. Acked-by: Mel Gorman > Signed-off-by: Andrea Arcangeli > --- > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -28,6 +28,7 @@ > */ > unsigned long transparent_hugepage_flags __read_mostly = > (1< + (1< (1< > /* default scan 8*512 pte (or vmas) every 30 second */ > -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org