From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754032Ab0KRTRk (ORCPT ); Thu, 18 Nov 2010 14:17:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:25478 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751107Ab0KRTRj (ORCPT ); Thu, 18 Nov 2010 14:17:39 -0500 Date: Thu, 18 Nov 2010 20:15:40 +0100 From: Andrea Arcangeli To: KOSAKI Motohiro Cc: linux-mm@kvack.org, Linus Torvalds , Andrew Morton , linux-kernel@vger.kernel.org, Marcelo Tosatti , Adam Litke , Avi Kivity , Hugh Dickins , Rik van Riel , Mel Gorman , Dave Hansen , Benjamin Herrenschmidt , Ingo Molnar , Mike Travis , KAMEZAWA Hiroyuki , Christoph Lameter , Chris Wright , bpicco@redhat.com, Balbir Singh , "Michael S. Tsirkin" , Peter Zijlstra , Johannes Weiner , Daisuke Nishimura , Chris Mason , Borislav Petkov Subject: Re: [PATCH 64 of 66] scale nr_rotated to balance memory pressure Message-ID: <20101118191540.GG30376@random.random> References: <54b5b2d012ff38e341ad.1288798119@v2.random> <20101109151605.BC78.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101109151605.BC78.A69D9226@jp.fujitsu.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 09, 2010 at 03:16:21PM +0900, KOSAKI Motohiro wrote: > I haven't seen this patch series carefully yet. So, probably > my question is dumb. Why don't we need to change ->recent_scanned[] too? That one is taken care by the prev patch where it is increased by 512 through nr_taken (after the previous patch the isolation methods now return in 4k units). What was left to update was the nr_rotated++ which is why this patch isn't touching the recent_scanned. Andrea From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with SMTP id 924146B004A for ; Thu, 18 Nov 2010 14:16:46 -0500 (EST) Date: Thu, 18 Nov 2010 20:15:40 +0100 From: Andrea Arcangeli Subject: Re: [PATCH 64 of 66] scale nr_rotated to balance memory pressure Message-ID: <20101118191540.GG30376@random.random> References: <54b5b2d012ff38e341ad.1288798119@v2.random> <20101109151605.BC78.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101109151605.BC78.A69D9226@jp.fujitsu.com> Sender: owner-linux-mm@kvack.org To: KOSAKI Motohiro Cc: linux-mm@kvack.org, Linus Torvalds , Andrew Morton , linux-kernel@vger.kernel.org, Marcelo Tosatti , Adam Litke , Avi Kivity , Hugh Dickins , Rik van Riel , Mel Gorman , Dave Hansen , Benjamin Herrenschmidt , Ingo Molnar , Mike Travis , KAMEZAWA Hiroyuki , Christoph Lameter , Chris Wright , bpicco@redhat.com, Balbir Singh , "Michael S. Tsirkin" , Peter Zijlstra , Johannes Weiner , Daisuke Nishimura , Chris Mason , Borislav Petkov List-ID: On Tue, Nov 09, 2010 at 03:16:21PM +0900, KOSAKI Motohiro wrote: > I haven't seen this patch series carefully yet. So, probably > my question is dumb. Why don't we need to change ->recent_scanned[] too? That one is taken care by the prev patch where it is increased by 512 through nr_taken (after the previous patch the isolation methods now return in 4k units). What was left to update was the nr_rotated++ which is why this patch isn't touching the recent_scanned. Andrea -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org