All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Leech <christopher.leech@linux.intel.com>
To: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH 4/5] qt602240_ts: add optional hooks for board specific reset logic
Date: Thu, 18 Nov 2010 11:46:28 -0800	[thread overview]
Message-ID: <20101118194628.GG1273@cleech-lnx.jf.intel.com> (raw)
In-Reply-To: <4CE50ED7.8000802@samsung.com>

On Thu, Nov 18, 2010 at 08:32:39PM +0900, Joonyoung Shim wrote:
> Hi, Chris.
>
> On 2010-11-17 오전 5:42, Chris Leech wrote:
>> Hooks for board specific setup and tear-down, to be used if the controllers
>> reset is wired to a GPIO pin.
>>
>> Signed-off-by: Chris Leech<christopher.leech@linux.intel.com>
>> ---
>>   drivers/input/touchscreen/qt602240_ts.c |    7 +++++++
>>   include/linux/i2c/qt602240_ts.h         |    4 ++++
>>   2 files changed, 11 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/input/touchscreen/qt602240_ts.c b/drivers/input/touchscreen/qt602240_ts.c
>> index 11055ec..efe975e 100644
>> --- a/drivers/input/touchscreen/qt602240_ts.c
>> +++ b/drivers/input/touchscreen/qt602240_ts.c
>> @@ -1307,6 +1307,11 @@ static int __devinit qt602240_probe(struct i2c_client *client,
>>
>>   	i2c_set_clientdata(client, data);
>>
>> +	if (data->pdata->hw_setup) {
>> +		error = data->pdata->hw_setup(client);
>> +		if (error)
>> +			goto err_free_object;
>> +	}
>>   	error = qt602240_initialize(data);
>>   	if (error)
>>   		goto err_free_object;
>> @@ -1376,6 +1381,8 @@ static int __devexit qt602240_remove(struct i2c_client *client)
>>   	sysfs_remove_group(&client->dev.kobj,&qt602240_attr_group);
>>   	free_irq(data->irq, data);
>>   	input_unregister_device(data->input_dev);
>> +	if (data->pdata->hw_teardown)
>> +		data->pdata->hw_teardown(client);
>>   	kfree(data->object_table);
>>   	kfree(data);
>>
>> diff --git a/include/linux/i2c/qt602240_ts.h b/include/linux/i2c/qt602240_ts.h
>> index d2aa1b6..764dd45 100644
>> --- a/include/linux/i2c/qt602240_ts.h
>> +++ b/include/linux/i2c/qt602240_ts.h
>> @@ -41,6 +41,10 @@ struct qt602240_platform_data {
>>   	 * platform_data).
>>   	 */
>>   	unsigned char trust_nvm;
>> +
>> +	/* Board-specific HW hooks; NULL if not needed */
>> +	int (*hw_setup) (struct i2c_client *client);
>> +	void (*hw_teardown) (struct i2c_client *client);
>
> Why does client need?

I'm not sure I understand your question.

If it's why are these hooks needed, I want to make sure that if the
reset pin is hooked up to a gpio the device is taken out of reset
properly.

If it's why the client argument is passed, it seemed like there should
be some way to identify the device.  You could have a platform with
multiple touchscreens.

- Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2010-11-18 19:46 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-16 20:41 [PATCH 0/4] qt602240_ts changes for Intel mid platform Chris Leech
2010-11-16 20:41 ` [PATCH 1/5] qt602240_ts: fix wrong sizeof in object table allocation Chris Leech
2010-11-18 11:16   ` Joonyoung Shim
2010-11-18 11:30     ` Joonyoung Shim
2010-11-16 20:41 ` [PATCH 2/5] qt602240_ts: move clearing of pending interrupt closer to request_threaded_irq Chris Leech
2010-11-18 12:53   ` Joonyoung Shim
2010-11-18 19:29     ` Chris Leech
2010-11-18 22:54       ` Dmitry Torokhov
2010-11-16 20:42 ` [PATCH 3/5] qt602240_ts: Trust factory configuration of touchscreen Chris Leech
2010-11-18 13:09   ` Joonyoung Shim
2010-11-18 19:41     ` Chris Leech
2010-11-16 20:42 ` [PATCH 4/5] qt602240_ts: add optional hooks for board specific reset logic Chris Leech
2010-11-18 11:32   ` Joonyoung Shim
2010-11-18 19:46     ` Chris Leech [this message]
2010-11-16 20:42 ` [PATCH 5/5] qt602240_ts: add mXT224 identifier to id_table, to match Intel mid firmware identifier Chris Leech
2010-11-18 11:34   ` Joonyoung Shim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101118194628.GG1273@cleech-lnx.jf.intel.com \
    --to=christopher.leech@linux.intel.com \
    --cc=jy0922.shim@samsung.com \
    --cc=linux-input@vger.kernel.org \
    --subject='Re: [PATCH 4/5] qt602240_ts: add optional hooks for board specific reset logic' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.