From: Mike Anderson <andmike@linux.vnet.ibm.com>
To: Mike Snitzer <snitzer@redhat.com>,
dm-devel@redhat.com, Mike Christie <michaelc@cs.wisc.edu>,
linux-scsi@vger.kernel.org
Subject: Re: [dm-devel] [PATCH v5] dm mpath: avoid call to blk_abort_queue by default
Date: Thu, 18 Nov 2010 12:39:55 -0800 [thread overview]
Message-ID: <20101118203954.GA6241@linux.vnet.ibm.com> (raw)
In-Reply-To: <20101118201841.GE30435@agk-dp.fab.redhat.com>
Alasdair G Kergon <agk@redhat.com> wrote:
> On Thu, Nov 18, 2010 at 03:07:33PM -0500, Mike Snitzer wrote:
> > It is expected that this race will be fixed in the near-term so it makes
> > little since to remove all associated code. Providing control over the
> > call to blk_abort_queue() facilitates continued testing and future
> > flexibility to opt-in to lower latency path deactivation. Opting to
> > enable this feature will emit a warning for the time being.
>
> Ah, but then the *feature* keyword - which is only going to be needed
> temporarily until it's fixed - becomes a permanent part of the interface...
>
> If it's broken, let's just disable it (#define-style) until it gets fixed.
> (And only if it doesn't get fixed in a reasonable amount of time, remove the
> code.)
I understand that if its broken that we could #define it out in dm or we
could #define the code in blk_abort_queue.
I believe the thought was that post addressing the race issue that
others may want control. As there maybe cases where the waking up of the
error_handler and a extra abort may not be wanted in all cases.
-andmike
--
Michael Anderson
andmike@linux.vnet.ibm.com
next prev parent reply other threads:[~2010-11-18 20:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-12 5:23 block_abort_queue (blk_abort_request) racing with scsi_request_fn Mike Anderson
2010-11-10 7:09 ` [dm-devel] " Mike Christie
2010-11-10 7:30 ` Mike Christie
2010-11-10 16:30 ` Mike Anderson
2010-11-10 21:16 ` Mike Christie
2010-11-12 17:54 ` Mike Anderson
2010-11-16 21:39 ` Mike Snitzer
2010-11-17 17:49 ` [dm-devel] " Mike Anderson
2010-11-17 21:55 ` Mike Snitzer
2010-11-18 4:40 ` [PATCH v2] dm mpath: add feature flag to control call to blk_abort_queue Mike Snitzer
2010-11-18 7:20 ` Mike Anderson
2010-11-18 15:48 ` Mike Snitzer
2010-11-18 15:48 ` [PATCH v3] " Mike Snitzer
2010-11-18 19:16 ` (unknown), Mike Snitzer
2010-11-18 19:21 ` Mike Snitzer
2010-11-18 19:19 ` [PATCH v4] dm mpath: avoid call to blk_abort_queue by default Mike Snitzer
2010-11-18 20:07 ` [PATCH v5] " Mike Snitzer
2010-11-18 20:18 ` [dm-devel] " Alasdair G Kergon
2010-11-18 20:39 ` Mike Anderson [this message]
2010-11-18 21:48 ` [PATCH] dm mpath: disable call to blk_abort_queue and related code Mike Snitzer
2010-11-23 1:00 ` [PATCH v2] dm mpath: revert "dm: Call blk_abort_queue on failed paths" Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101118203954.GA6241@linux.vnet.ibm.com \
--to=andmike@linux.vnet.ibm.com \
--cc=dm-devel@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.