Re: [PATCH 2/5] qt602240_ts: move clearing of pending interrupt closer to request_threaded_irq

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Chris Leech <christopher.leech@linux.intel.com>
Cc: Joonyoung Shim <jy0922.shim@samsung.com>, linux-input@vger.kernel.org
Subject: Re: [PATCH 2/5] qt602240_ts: move clearing of pending interrupt closer to request_threaded_irq
Date: Thu, 18 Nov 2010 14:54:12 -0800	[thread overview]
Message-ID: <20101118225412.GA732@core.coreip.homeip.net> (raw)
In-Reply-To: <20101118192902.GE1273@cleech-lnx.jf.intel.com>

On Thu, Nov 18, 2010 at 11:29:02AM -0800, Chris Leech wrote:
> On Thu, Nov 18, 2010 at 09:53:13PM +0900, Joonyoung Shim wrote:
> > Hi, Chris.
> >
> > On 2010-11-17 오전 5:41, Chris Leech wrote:
> >> I've seen interrupts asserted on the CHG pin between the call to make_highcgh()
> >> during initialization and registering the interrupt handler, leaving CHG low
> >> and no events get passed up.
> >>
> >
> > The CHG pin can be affected by control of gpios connected to touch
> > chip. Could you check it? I think it doesn't matter where
> > make_highchg() exists actually.
> 
> My understanding is that CHG is to be used to trigger interrupts, and
> the attached gpio should be set as an input.  I'm not sure trying to set
> the value from the gpio side is going to work.
> 
> The problem I was seeing was the attached gpio configured as a
> falling-edge-triggered interrupt stuck in the low state, and
> qt602240_interrupt is never called.  What that says to me is that CHG
> transitioned low before the interrupt handler was registered.  From what
> I can see, the only way to reset CHG is to clear the queue of pending
> messages, which is what make_highchg does.
> 

I wonder if it should actually go into qt602240_start().

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html