From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760105Ab0KSBUW (ORCPT ); Thu, 18 Nov 2010 20:20:22 -0500 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:47855 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754570Ab0KSBUV (ORCPT ); Thu, 18 Nov 2010 20:20:21 -0500 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Date: Fri, 19 Nov 2010 10:14:27 +0900 From: KAMEZAWA Hiroyuki To: Andrea Arcangeli Cc: linux-mm@kvack.org, Linus Torvalds , Andrew Morton , linux-kernel@vger.kernel.org, Marcelo Tosatti , Adam Litke , Avi Kivity , Hugh Dickins , Rik van Riel , Mel Gorman , Dave Hansen , Benjamin Herrenschmidt , Ingo Molnar , Mike Travis , Christoph Lameter , Chris Wright , bpicco@redhat.com, KOSAKI Motohiro , Balbir Singh , "Michael S. Tsirkin" , Peter Zijlstra , Johannes Weiner , Daisuke Nishimura , Chris Mason , Borislav Petkov Subject: Re: [PATCH 38 of 66] memcontrol: try charging huge pages from stock Message-Id: <20101119101427.45d78929.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <9d26d3daf23632b20a7b.1288798093@v2.random> References: <9d26d3daf23632b20a7b.1288798093@v2.random> Organization: FUJITSU Co. LTD. X-Mailer: Sylpheed 3.0.3 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 03 Nov 2010 16:28:13 +0100 Andrea Arcangeli wrote: > From: Johannes Weiner > > The stock unit is just bytes, there is no reason to only take normal > pages from it. > > Signed-off-by: Johannes Weiner > Signed-off-by: Andrea Arcangeli nonsense. The stock size is CHARGE_SIZE=32*PAGE_SIZE at maximum. When we make this to be larger than HUGEPAGE size, 2M per cpu at least. This means memcg's resource "usage" accounting will have 128MB inaccuracy. Nack. Thanks, -Kame From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with SMTP id D61ED6B004A for ; Thu, 18 Nov 2010 20:20:17 -0500 (EST) Received: from m2.gw.fujitsu.co.jp ([10.0.50.72]) by fgwmail7.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id oAJ1KFJq001907 for (envelope-from kamezawa.hiroyu@jp.fujitsu.com); Fri, 19 Nov 2010 10:20:15 +0900 Received: from smail (m2 [127.0.0.1]) by outgoing.m2.gw.fujitsu.co.jp (Postfix) with ESMTP id BB0FF45DE63 for ; Fri, 19 Nov 2010 10:20:14 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (s2.gw.fujitsu.co.jp [10.0.50.92]) by m2.gw.fujitsu.co.jp (Postfix) with ESMTP id 8144645DE4F for ; Fri, 19 Nov 2010 10:20:14 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id 3A5391DB8042 for ; Fri, 19 Nov 2010 10:20:14 +0900 (JST) Received: from ml14.s.css.fujitsu.com (ml14.s.css.fujitsu.com [10.249.87.104]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id DB9F7E08002 for ; Fri, 19 Nov 2010 10:20:13 +0900 (JST) Date: Fri, 19 Nov 2010 10:14:27 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [PATCH 38 of 66] memcontrol: try charging huge pages from stock Message-Id: <20101119101427.45d78929.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <9d26d3daf23632b20a7b.1288798093@v2.random> References: <9d26d3daf23632b20a7b.1288798093@v2.random> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Andrea Arcangeli Cc: linux-mm@kvack.org, Linus Torvalds , Andrew Morton , linux-kernel@vger.kernel.org, Marcelo Tosatti , Adam Litke , Avi Kivity , Hugh Dickins , Rik van Riel , Mel Gorman , Dave Hansen , Benjamin Herrenschmidt , Ingo Molnar , Mike Travis , Christoph Lameter , Chris Wright , bpicco@redhat.com, KOSAKI Motohiro , Balbir Singh , "Michael S. Tsirkin" , Peter Zijlstra , Johannes Weiner , Daisuke Nishimura , Chris Mason , Borislav Petkov List-ID: On Wed, 03 Nov 2010 16:28:13 +0100 Andrea Arcangeli wrote: > From: Johannes Weiner > > The stock unit is just bytes, there is no reason to only take normal > pages from it. > > Signed-off-by: Johannes Weiner > Signed-off-by: Andrea Arcangeli nonsense. The stock size is CHARGE_SIZE=32*PAGE_SIZE at maximum. When we make this to be larger than HUGEPAGE size, 2M per cpu at least. This means memcg's resource "usage" accounting will have 128MB inaccuracy. Nack. Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org