From: zkabelac@sourceware.org <zkabelac@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW lib/commands/toolcontext.c
Date: 24 Nov 2010 09:34:35 -0000 [thread overview]
Message-ID: <20101124093435.4218.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: zkabelac at sourceware.org 2010-11-24 09:34:35
Modified files:
. : WHATS_NEW
lib/commands : toolcontext.c
Log message:
Fix resource leak of dlopened pointer
Add missing dlclose in _init_formats() error path.
Use return_0 to print stack trace from the call.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1806&r2=1.1807
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/commands/toolcontext.c.diff?cvsroot=lvm2&r1=1.108&r2=1.109
--- LVM2/WHATS_NEW 2010/11/23 21:19:45 1.1806
+++ LVM2/WHATS_NEW 2010/11/24 09:34:34 1.1807
@@ -1,5 +1,6 @@
Version 2.02.78 -
====================================
+ Fix missing dlclose in _init_formats() error path from init_format call.
Fix missing fclose for _umount() in dmeventd snapshot plugin.
Fix out-of-scope variable usage in process_each_lv().
Fix dm_task_destroy(NULL) call in _node_clear_table() error path.
--- LVM2/lib/commands/toolcontext.c 2010/11/11 17:29:05 1.108
+++ LVM2/lib/commands/toolcontext.c 2010/11/24 09:34:35 1.109
@@ -814,8 +814,11 @@
return 0;
}
- if (!(fmt = init_format_fn(cmd)))
- return 0;
+ if (!(fmt = init_format_fn(cmd))) {
+ dlclose(lib);
+ return_0;
+ }
+
fmt->library = lib;
dm_list_add(&cmd->formats, &fmt->list);
}
next reply other threads:[~2010-11-24 9:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 9:34 zkabelac [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-05-23 13:02 LVM2 ./WHATS_NEW lib/commands/toolcontext.c zkabelac
2012-03-23 9:42 zkabelac
2012-02-27 10:05 zkabelac
2012-02-08 10:46 zkabelac
2011-07-08 16:49 agk
2011-06-28 0:23 agk
2010-04-30 12:37 zkabelac
2009-07-21 20:00 mpatocka
2009-07-14 12:17 mbroz
2009-06-15 11:56 mbroz
2009-04-02 20:46 taka
2007-02-08 17:31 agk
2007-01-23 16:03 agk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101124093435.4218.qmail@sourceware.org \
--to=zkabelac@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.