From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCHv6 00/16] boot order specification Date: Sun, 28 Nov 2010 19:23:20 +0200 Message-ID: <20101128172320.GG12874@redhat.com> References: <1290012243-6087-1-git-send-email-gleb@redhat.com> <20101123153141.GD25606@redhat.com> <4CEBE7F4.9080200@linux.vnet.ibm.com> <4CF1706A.3000507@redhat.com> <20101128075404.GF6897@redhat.com> <20101128131352.GA12874@redhat.com> <20101128131900.GC2187@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , Anthony Liguori , qemu-devel@nongnu.org, kvm@vger.kernel.org, blauwirbel@gmail.com, armbru@redhat.com, alex.williamson@redhat.com, kevin@koconnor.net, Anthony Liguori To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:25343 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753626Ab0K1RXr (ORCPT ); Sun, 28 Nov 2010 12:23:47 -0500 Content-Disposition: inline In-Reply-To: <20101128131900.GC2187@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, Nov 28, 2010 at 03:19:00PM +0200, Gleb Natapov wrote: > On Sun, Nov 28, 2010 at 03:13:52PM +0200, Michael S. Tsirkin wrote: > > On Sun, Nov 28, 2010 at 09:54:04AM +0200, Gleb Natapov wrote: > > > On Sat, Nov 27, 2010 at 10:56:10PM +0200, Avi Kivity wrote: > > > > On 11/23/2010 06:12 PM, Anthony Liguori wrote: > > > > >On 11/23/2010 09:31 AM, Gleb Natapov wrote: > > > > >>Anthony, Blue > > > > >> > > > > >>No comments on this patch series for almost a week. Can it be applied? > > > > > > > > > >Does that mean everyone's happy or have folks not gotten around to > > > > >review it? > > > > > > > > > >IOW, last call if you have objections :-) > > > > > > > > > > > > > I haven't reviewed this - I trust the author and maintainers to get > > > > it right. > > > > > > > > But I notice the there is no documentation - surely some is needed? > > > > > > > > > > The patch creates Openfirmware device path from qdev > > > hierarchy. Each element of a device path depends on type of a bus > > > the device resides on. You can find various bus bindings here: > > > http://playground.sun.com/1275/bindings/ and main spec is here > > > > sun.com links have a tendency to disappear nowdays :) > > Is this the official location? Aren't bindings part of some standard? > I think this is official location. > > > > It also worries me that PCI Express bindings are in a 'proposal' form > > from August 2004. The PCI bindings are from 1994. They are likely to miss > > some recent technology advancements :) > > > > > > Further, while this last document which is only 28 page in length, is > > not readable by itself: one must first digest the openfirmware spec. > > However ... > > > > > http://forthworks.com/standards/of1275.pdf. > > > > That's 266 pages of a specification. I am guessing that most of it is > > irrelevant for the task in question? Can we have a small text document > > including just the path format, please? > > > So basically you are complaining that reading specs is difficult. It is. That's > life. Well, the specific format used is undocumented. Patch borrowed bits from various specs, but it's undocumented which bits, and from which specs. I do realize you had to go over all of these specs and do the difficult work to come up with the format, but please write documentation for the rest of us. > -- > Gleb. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=39513 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PMkya-00069q-K0 for qemu-devel@nongnu.org; Sun, 28 Nov 2010 12:23:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PMkyY-0006lh-LV for qemu-devel@nongnu.org; Sun, 28 Nov 2010 12:23:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45781) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PMkyY-0006lZ-Bp for qemu-devel@nongnu.org; Sun, 28 Nov 2010 12:23:46 -0500 Date: Sun, 28 Nov 2010 19:23:20 +0200 From: "Michael S. Tsirkin" Message-ID: <20101128172320.GG12874@redhat.com> References: <1290012243-6087-1-git-send-email-gleb@redhat.com> <20101123153141.GD25606@redhat.com> <4CEBE7F4.9080200@linux.vnet.ibm.com> <4CF1706A.3000507@redhat.com> <20101128075404.GF6897@redhat.com> <20101128131352.GA12874@redhat.com> <20101128131900.GC2187@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101128131900.GC2187@redhat.com> Subject: [Qemu-devel] Re: [PATCHv6 00/16] boot order specification List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gleb Natapov Cc: Anthony Liguori , kvm@vger.kernel.org, armbru@redhat.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, Anthony Liguori , alex.williamson@redhat.com, kevin@koconnor.net, Avi Kivity On Sun, Nov 28, 2010 at 03:19:00PM +0200, Gleb Natapov wrote: > On Sun, Nov 28, 2010 at 03:13:52PM +0200, Michael S. Tsirkin wrote: > > On Sun, Nov 28, 2010 at 09:54:04AM +0200, Gleb Natapov wrote: > > > On Sat, Nov 27, 2010 at 10:56:10PM +0200, Avi Kivity wrote: > > > > On 11/23/2010 06:12 PM, Anthony Liguori wrote: > > > > >On 11/23/2010 09:31 AM, Gleb Natapov wrote: > > > > >>Anthony, Blue > > > > >> > > > > >>No comments on this patch series for almost a week. Can it be applied? > > > > > > > > > >Does that mean everyone's happy or have folks not gotten around to > > > > >review it? > > > > > > > > > >IOW, last call if you have objections :-) > > > > > > > > > > > > > I haven't reviewed this - I trust the author and maintainers to get > > > > it right. > > > > > > > > But I notice the there is no documentation - surely some is needed? > > > > > > > > > > The patch creates Openfirmware device path from qdev > > > hierarchy. Each element of a device path depends on type of a bus > > > the device resides on. You can find various bus bindings here: > > > http://playground.sun.com/1275/bindings/ and main spec is here > > > > sun.com links have a tendency to disappear nowdays :) > > Is this the official location? Aren't bindings part of some standard? > I think this is official location. > > > > It also worries me that PCI Express bindings are in a 'proposal' form > > from August 2004. The PCI bindings are from 1994. They are likely to miss > > some recent technology advancements :) > > > > > > Further, while this last document which is only 28 page in length, is > > not readable by itself: one must first digest the openfirmware spec. > > However ... > > > > > http://forthworks.com/standards/of1275.pdf. > > > > That's 266 pages of a specification. I am guessing that most of it is > > irrelevant for the task in question? Can we have a small text document > > including just the path format, please? > > > So basically you are complaining that reading specs is difficult. It is. That's > life. Well, the specific format used is undocumented. Patch borrowed bits from various specs, but it's undocumented which bits, and from which specs. I do realize you had to go over all of these specs and do the difficult work to come up with the format, but please write documentation for the rest of us. > -- > Gleb.