From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Wed, 01 Dec 2010 09:03:42 +0100 Subject: [U-Boot] onenand_ipl config.mk cleanup (was: no subject) In-Reply-To: References: <20101128201430.51BCD1352CD@gemini.denx.de> Message-ID: <20101201080342.D5630134FEF@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Minkyu Kang, In message you wrote: > > > "onenand_ipl/board/apollon/config.mk" and > > "onenand_ipl/board/vpac270/config.mk" define CONFIG_SYS_TEXT_BASE; > > do you think it is possible to move these definitions into the > > respective board config files and remove the then empty "config.mk" > > files? > > > > It is hard to move into board config file, because of usually use > different TEXT_BASE on IPL. Well, we can probably use #ifdef's, like we do for boards that boot from NAND flash, which have essentially the same situation. > I think, it can be moved into Makefile directly. No, that's not a good idea. Makefiles should not contain configuration data. I want to move as much of this as possible into the board config files, so we have it all in a single place. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de A failure will not appear until a unit has passed final inspection.