From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 1 Dec 2010 11:28:56 -0800 From: Greg KH Subject: Re: [PATCH] drivers: char: hvc: add arm JTAG DCC console support Message-ID: <20101201192856.GA731@suse.de> References: <1291145141-18301-1-git-send-email-dwalker@codeaurora.org> <4CF5DD63.40803@codeaurora.org> <1291229696.14404.39.camel@c-dwalke-linux.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1291229696.14404.39.camel@c-dwalke-linux.qualcomm.com> To: Daniel Walker Cc: Stephen Boyd , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Tony Lindgren , Arnd Bergmann , Nicolas Pitre , Mike Frysinger , Andrew Morton , Alan Cox , Randy Dunlap , FUJITA Tomonori , linuxppc-dev@lists.ozlabs.org List-ID: On Wed, Dec 01, 2010 at 10:54:56AM -0800, Daniel Walker wrote: > On Tue, 2010-11-30 at 21:30 -0800, Stephen Boyd wrote: > > On 11/30/2010 11:25 AM, Daniel Walker wrote: > > > @@ -682,6 +682,15 @@ config HVC_UDBG > > > select HVC_DRIVER > > > default n > > > > > > +config HVC_DCC > > > + bool "ARM JTAG DCC console" > > > + depends on ARM > > > + select HVC_DRIVER > > > + help > > > + This console uses the JTAG DCC on ARM to create a console under the HVC > > > > Looks like you added one too many spaces for indent here. > > The first line is fine, but the other two might need an extra space. For this, or any other changes you want, I'll gladly take a follow-on patch as this one is already in my tty-next tree. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by ozlabs.org (Postfix) with ESMTP id 3CC86B6EF1 for ; Thu, 2 Dec 2010 06:30:06 +1100 (EST) Date: Wed, 1 Dec 2010 11:28:56 -0800 From: Greg KH To: Daniel Walker Subject: Re: [PATCH] drivers: char: hvc: add arm JTAG DCC console support Message-ID: <20101201192856.GA731@suse.de> References: <1291145141-18301-1-git-send-email-dwalker@codeaurora.org> <4CF5DD63.40803@codeaurora.org> <1291229696.14404.39.camel@c-dwalke-linux.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1291229696.14404.39.camel@c-dwalke-linux.qualcomm.com> Cc: Randy Dunlap , Mike Frysinger , Arnd Bergmann , Nicolas Pitre , Tony Lindgren , linux-arm-msm@vger.kernel.org, Stephen Boyd , linux-kernel@vger.kernel.org, FUJITA Tomonori , Andrew Morton , linuxppc-dev@lists.ozlabs.org, Alan Cox List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Dec 01, 2010 at 10:54:56AM -0800, Daniel Walker wrote: > On Tue, 2010-11-30 at 21:30 -0800, Stephen Boyd wrote: > > On 11/30/2010 11:25 AM, Daniel Walker wrote: > > > @@ -682,6 +682,15 @@ config HVC_UDBG > > > select HVC_DRIVER > > > default n > > > > > > +config HVC_DCC > > > + bool "ARM JTAG DCC console" > > > + depends on ARM > > > + select HVC_DRIVER > > > + help > > > + This console uses the JTAG DCC on ARM to create a console under the HVC > > > > Looks like you added one too many spaces for indent here. > > The first line is fine, but the other two might need an extra space. For this, or any other changes you want, I'll gladly take a follow-on patch as this one is already in my tty-next tree. thanks, greg k-h