From mboxrd@z Thu Jan 1 00:00:00 1970 From: jacob pan Subject: Re: [RFC PATCH 1/2] cgroup: add per cgroup timer_slack_ns Date: Thu, 2 Dec 2010 12:45:59 -0800 Message-ID: <20101202124559.0a7128de__31424.1796070293$1291322867$gmane$org@jacob-laptop> References: <1291230012-9536-1-git-send-email-jacob.jun.pan@linux.intel.com> <1291230012-9536-2-git-send-email-jacob.jun.pan@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Paul Menage Cc: de Ven , container cgroup , LKML , Arjan-FOgKQjlUJ6BQetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: containers.vger.kernel.org On Wed, 1 Dec 2010 12:17:20 -0800 Paul Menage wrote: > When multiple hierarchies are mounted a task will be in one cgroup on > each hierarchy - which cgroup's timer_slack_ns value should be used > for it? > > This doesn't belong in the generic cgroups framework. It sounds like > it's something that should be its own subsystem, or else part of > something like the cpu subsystem. good point. the current behavior is that the timer_slack_ns value will be assigned by the last hierarchy it attaches to, which might not be desirable. I guess timer_slack_ns alone cannot qualify for a new subsystem, I will try to fit it into cpuset. Thanks for the review, Jacob