All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Dan Murphy <dmurphy@ti.com>
Cc: linux-omap@vger.kernel.org, b-cousson@ti.com, paul@pwsan.com,
	khilman@deeprootsystems.com
Subject: Re: [PATCH] OMAP MUX framework changes
Date: Thu, 2 Dec 2010 14:02:37 -0800	[thread overview]
Message-ID: <20101202220237.GY17222@atomide.com> (raw)
In-Reply-To: <20101119174721.GT9264@atomide.com>

* Tony Lindgren <tony@atomide.com> [101119 09:38]:
> * Dan Murphy <dmurphy@ti.com> [101117 09:58]:
> > --- a/arch/arm/mach-omap2/mux.c
> > +++ b/arch/arm/mach-omap2/mux.c
> >  
> > +static struct omap_mux *omap_mux_get_by_mux(struct omap_mux_partition *partition,
> > +					char *name)
> > +{
> > +	struct omap_mux_entry *e;
> > +	int i = 0;
> > +
> > +	list_for_each_entry(e, &partition->muxmodes, node) {
> > +		struct omap_mux *m = &e->mux;
> > +		for (i = 0; i < OMAP_MUX_NR_MODES; i++) {
> > +			if (m->muxnames[i] == NULL)
> > +				break;
> > +			else if (!strcmp(name, m->muxnames[i]))
> > +				return m;
> > +		}
> > +	}
> > +
> > +	return NULL;
> > +}
> 
> Hmm turns out we almost have this already in _omap_mux_init_signal.
> Also we need to know the mux mode value to make use of this, so
> how about the patch below instead?

Will post a better version soon.

Tony

      reply	other threads:[~2010-12-02 22:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-17 18:06 [PATCH] OMAP MUX framework changes Dan Murphy
2010-11-18 17:57 ` Tony Lindgren
2010-11-18 21:01   ` Cousson, Benoit
2010-11-18 21:29     ` Tony Lindgren
2010-11-19 17:47 ` Tony Lindgren
2010-12-02 22:02   ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101202220237.GY17222@atomide.com \
    --to=tony@atomide.com \
    --cc=b-cousson@ti.com \
    --cc=dmurphy@ti.com \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.