Re: [PATCH 5/5 v5] usb: musb: Using runtime pm APIs for musb.

[Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>]

hi,

On Fri, Dec 10, 2010 at 08:05:39PM +0530, Hema HK wrote:
>Calling runtime pm APIs pm_runtime_put_sync() and pm_runtime_get_sync()
>for enabling/disabling the clocks, sysconfig settings.
>
>enable clock, configure no-idle/standby when active and configure force idle/standby
>and disable clock when idled. This is taken care by the runtime framework when
>driver calls the pm_runtime_get_sync and pm_runtime_put_sync APIs.
>Need to configure MUSB into force standby and force idle mode when usb not used
>
>Signed-off-by: Hema HK <hemahk-l0cyMroinI0@public.gmane.org>
>Cc: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
>Cc: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
>Cc: Kevin Hilman <khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
>Cc: Cousson, Benoit <b-cousson-l0cyMroinI0@public.gmane.org>
>Cc: Paul Walmsley <paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org>
>---
>
> drivers/usb/musb/musb_core.h |    2 -
> drivers/usb/musb/omap2430.c  |   80 +++++++++++--------------------------------
> 2 files changed, 23 insertions(+), 59 deletions(-)

Now I see you removed the runtime_resume and runtime_suspend calls from
musb_core. Won't we loose context in that case ?

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html