From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759801Ab0LNRjw (ORCPT ); Tue, 14 Dec 2010 12:39:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:4345 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759787Ab0LNRju (ORCPT ); Tue, 14 Dec 2010 12:39:50 -0500 Date: Tue, 14 Dec 2010 18:38:21 +0100 From: Andrea Arcangeli To: KAMEZAWA Hiroyuki Cc: linux-mm@kvack.org, Linus Torvalds , Andrew Morton , linux-kernel@vger.kernel.org, Marcelo Tosatti , Adam Litke , Avi Kivity , Hugh Dickins , Rik van Riel , Mel Gorman , Dave Hansen , Benjamin Herrenschmidt , Ingo Molnar , Mike Travis , Christoph Lameter , Chris Wright , bpicco@redhat.com, KOSAKI Motohiro , Balbir Singh , "Michael S. Tsirkin" , Peter Zijlstra , Johannes Weiner , Daisuke Nishimura , Chris Mason , Borislav Petkov Subject: Re: [PATCH 38 of 66] memcontrol: try charging huge pages from stock Message-ID: <20101214173821.GI5638@random.random> References: <9d26d3daf23632b20a7b.1288798093@v2.random> <20101119101427.45d78929.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101119101427.45d78929.kamezawa.hiroyu@jp.fujitsu.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 19, 2010 at 10:14:27AM +0900, KAMEZAWA Hiroyuki wrote: > On Wed, 03 Nov 2010 16:28:13 +0100 > Andrea Arcangeli wrote: > > > From: Johannes Weiner > > > > The stock unit is just bytes, there is no reason to only take normal > > pages from it. > > > > Signed-off-by: Johannes Weiner > > Signed-off-by: Andrea Arcangeli > > nonsense. The stock size is CHARGE_SIZE=32*PAGE_SIZE at maximum. > When we make this to be larger than HUGEPAGE size, 2M per cpu at least. > This means memcg's resource "usage" accounting will have 128MB inaccuracy. > > Nack. Removed, thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with SMTP id 25AEF6B008C for ; Tue, 14 Dec 2010 12:39:11 -0500 (EST) Date: Tue, 14 Dec 2010 18:38:21 +0100 From: Andrea Arcangeli Subject: Re: [PATCH 38 of 66] memcontrol: try charging huge pages from stock Message-ID: <20101214173821.GI5638@random.random> References: <9d26d3daf23632b20a7b.1288798093@v2.random> <20101119101427.45d78929.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101119101427.45d78929.kamezawa.hiroyu@jp.fujitsu.com> Sender: owner-linux-mm@kvack.org To: KAMEZAWA Hiroyuki Cc: linux-mm@kvack.org, Linus Torvalds , Andrew Morton , linux-kernel@vger.kernel.org, Marcelo Tosatti , Adam Litke , Avi Kivity , Hugh Dickins , Rik van Riel , Mel Gorman , Dave Hansen , Benjamin Herrenschmidt , Ingo Molnar , Mike Travis , Christoph Lameter , Chris Wright , bpicco@redhat.com, KOSAKI Motohiro , Balbir Singh , "Michael S. Tsirkin" , Peter Zijlstra , Johannes Weiner , Daisuke Nishimura , Chris Mason , Borislav Petkov List-ID: On Fri, Nov 19, 2010 at 10:14:27AM +0900, KAMEZAWA Hiroyuki wrote: > On Wed, 03 Nov 2010 16:28:13 +0100 > Andrea Arcangeli wrote: > > > From: Johannes Weiner > > > > The stock unit is just bytes, there is no reason to only take normal > > pages from it. > > > > Signed-off-by: Johannes Weiner > > Signed-off-by: Andrea Arcangeli > > nonsense. The stock size is CHARGE_SIZE=32*PAGE_SIZE at maximum. > When we make this to be larger than HUGEPAGE size, 2M per cpu at least. > This means memcg's resource "usage" accounting will have 128MB inaccuracy. > > Nack. Removed, thanks! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org