From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:38882 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753603Ab0LONzK (ORCPT ); Wed, 15 Dec 2010 08:55:10 -0500 Date: Wed, 15 Dec 2010 05:55:08 -0800 From: David Brown Subject: Re: [PATCH 2/7] msm: Physical offset for MSM8960 Message-ID: <20101215135508.GB8682@huya.qualcomm.com> References: <1292384961-8851-1-git-send-email-stepanm@codeaurora.org> <1292384961-8851-3-git-send-email-stepanm@codeaurora.org> <4D08BFFC.3020103@ru.mvista.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D08BFFC.3020103@ru.mvista.com> Sender: linux-arm-msm-owner@vger.kernel.org List-ID: To: Sergei Shtylyov Cc: Stepan Moskovchenko , davidb@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org On Wed, Dec 15, 2010 at 04:17:48PM +0300, Sergei Shtylyov wrote: > On 15-12-2010 6:49, Stepan Moskovchenko wrote: > > > Add the physical memory offset value for the Qualcomm > > MSM8960 chip. > > > Signed-off-by: Stepan Moskovchenko > [...] > > > diff --git a/arch/arm/mach-msm/include/mach/memory.h b/arch/arm/mach-msm/include/mach/memory.h > > index 070e17d..014bbd3 100644 > > --- a/arch/arm/mach-msm/include/mach/memory.h > > +++ b/arch/arm/mach-msm/include/mach/memory.h > > @@ -25,6 +25,8 @@ > > #define PHYS_OFFSET UL(0x00200000) > > #elif defined(CONFIG_ARCH_MSM8X60) > > #define PHYS_OFFSET UL(0x40200000) > > +#elif defined(CONFIG_ARCH_MSM8960) > > +#define PHYS_OFFSET UL(0x40200000) > > Why not: > > -#elif defined(CONFIG_ARCH_MSM8X60) > +#elif defined(CONFIG_ARCH_MSM8X60) || defined(CONFIG_ARCH_MSM8960) I guess it's a matter of style, and what one is trying to emphasize. Having each one listed makes it easier to change them individually. The file is just a listing of the addresses of each chip, so I don't see much reason to try and compact it. Thanks, David -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. From mboxrd@z Thu Jan 1 00:00:00 1970 From: davidb@codeaurora.org (David Brown) Date: Wed, 15 Dec 2010 05:55:08 -0800 Subject: [PATCH 2/7] msm: Physical offset for MSM8960 In-Reply-To: <4D08BFFC.3020103@ru.mvista.com> References: <1292384961-8851-1-git-send-email-stepanm@codeaurora.org> <1292384961-8851-3-git-send-email-stepanm@codeaurora.org> <4D08BFFC.3020103@ru.mvista.com> Message-ID: <20101215135508.GB8682@huya.qualcomm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Dec 15, 2010 at 04:17:48PM +0300, Sergei Shtylyov wrote: > On 15-12-2010 6:49, Stepan Moskovchenko wrote: > > > Add the physical memory offset value for the Qualcomm > > MSM8960 chip. > > > Signed-off-by: Stepan Moskovchenko > [...] > > > diff --git a/arch/arm/mach-msm/include/mach/memory.h b/arch/arm/mach-msm/include/mach/memory.h > > index 070e17d..014bbd3 100644 > > --- a/arch/arm/mach-msm/include/mach/memory.h > > +++ b/arch/arm/mach-msm/include/mach/memory.h > > @@ -25,6 +25,8 @@ > > #define PHYS_OFFSET UL(0x00200000) > > #elif defined(CONFIG_ARCH_MSM8X60) > > #define PHYS_OFFSET UL(0x40200000) > > +#elif defined(CONFIG_ARCH_MSM8960) > > +#define PHYS_OFFSET UL(0x40200000) > > Why not: > > -#elif defined(CONFIG_ARCH_MSM8X60) > +#elif defined(CONFIG_ARCH_MSM8X60) || defined(CONFIG_ARCH_MSM8960) I guess it's a matter of style, and what one is trying to emphasize. Having each one listed makes it easier to change them individually. The file is just a listing of the addresses of each chip, so I don't see much reason to try and compact it. Thanks, David -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.