From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Kenji Wakamiya <wkenji@jp.fujitsu.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] pvops: fix "xm save -c" issue
Date: Wed, 15 Dec 2010 10:40:21 -0500 [thread overview]
Message-ID: <20101215154021.GB28984@dumpdata.com> (raw)
In-Reply-To: <4D08417E.7060104@jp.fujitsu.com>
On Wed, Dec 15, 2010 at 01:18:06PM +0900, Kenji Wakamiya wrote:
> Hi Konrad, thank you for your response,
>
> Konrad Rzeszutek Wilk wrote:
> >On Tue, Dec 14, 2010 at 02:31:36PM +0900, Kenji Wakamiya wrote:
> >>Hi,
> >>
> >>I'm investigating the issue of "xm save -c" in case of PV guests.
> >>Then, I tried to prevent calling dpm_resume_end() when suspend was
> >>canceled. It seems to work fine about blk and net.
> >>How about this?
> >
> >
> >Could you give more details of what the failure is?
>
> "xm save -c" saves domain state to storage and leaves it running after
> creating snapshot. When this command is executed for a pvops
> guest (xen/stable-2.6.32.x), the guest will hang up after accessing to
> devices.
>
> When the guest is unapused, stop_machine() in manage.c returns as the
> suspend is cancelled. In that case, I think dpm_resume_end() should
> not be called after stop_machine().
>
> I tested vbd and net, the guest did not hang.
OK. Does 'xm save' (so no -c) and then resume work with this patch
(I would think so, but I am curious whether you tested this).
> But I'm not sure if this is a right way...
Looks OK to me, just want to make sure that the normal 'xm save' still
works after this.
next prev parent reply other threads:[~2010-12-15 15:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 5:31 [PATCH] pvops: fix "xm save -c" issue Kenji Wakamiya
2010-12-14 14:59 ` Konrad Rzeszutek Wilk
2010-12-15 4:18 ` Kenji Wakamiya
2010-12-15 15:40 ` Konrad Rzeszutek Wilk [this message]
2010-12-16 5:49 ` Kenji Wakamiya
2010-12-17 9:43 ` Ian Campbell
2011-01-10 17:01 ` Konrad Rzeszutek Wilk
2011-01-21 5:35 ` Kenji Wakamiya
2011-01-21 6:28 ` SUZUKI, Kazuhiro
2011-01-21 9:14 ` Ian Campbell
2011-01-25 7:23 ` SUZUKI, Kazuhiro
2011-01-25 16:32 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101215154021.GB28984@dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=wkenji@jp.fujitsu.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.