All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
Cc: "SZEDER Gábor" <szeder@ira.uka.de>,
	git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH] completion: add missing configuration variables
Date: Thu, 16 Dec 2010 09:28:16 -0500	[thread overview]
Message-ID: <20101216142816.GB9945@sigill.intra.peff.net> (raw)
In-Reply-To: <alpine.DEB.1.10.1012160810440.25560@debian>

On Thu, Dec 16, 2010 at 08:14:54AM +0100, Martin von Zweigbergk wrote:

> > On Wed, Dec 15, 2010 at 08:44:45PM +0100, Martin von Zweigbergk wrote:
> > > On Wed, 15 Dec 2010, Jeff King wrote:
> > > > As an aside, I would think "--unset" should actually choose from the set
> > > > of configured variables for completion (i.e., "git config --list | cut
> > > > -d= -f1"). But that would obviously be a separate patch.
> > > 
> > > Good point. I'll put it on my todo.
> > 
> > It already works that way since 0065236 (bash completion: complete
> > variable names for "git config" with options, 2009-05-08).
> 
> Nice. Thanks. Removed from my todo :-). Then I don't see any reason at
> all to keep color.grep.external and add.ignore-errors.

Agreed. Thanks.

-Peff

  reply	other threads:[~2010-12-16 14:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-15  6:46 [PATCH] completion: add missing configuration variables Martin von Zweigbergk
2010-12-15 13:00 ` Jeff King
2010-12-15 19:44   ` Martin von Zweigbergk
2010-12-16  4:23     ` Jeff King
2010-12-17 20:52       ` Junio C Hamano
2010-12-17 21:04         ` Jeff King
2010-12-16 12:42     ` SZEDER Gábor
2010-12-16  7:14       ` Martin von Zweigbergk
2010-12-16 14:28         ` Jeff King [this message]
2010-12-17 20:44   ` Junio C Hamano
2010-12-17 21:21     ` Jeff King
2010-12-20 15:18 ` [PATCH v2] " Martin von Zweigbergk
2010-12-20 21:20   ` Jeff King
2010-12-21  1:22     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101216142816.GB9945@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=martin.von.zweigbergk@gmail.com \
    --cc=szeder@ira.uka.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.