From: Greg KH <gregkh@suse.de>
To: Robert Morell <rmorell@nvidia.com>
Cc: David Brownell <dbrownell@users.sourceforge.net>,
Benoit Goby <benoit@android.com>,
Alan Stern <stern@rowland.harvard.edu>,
Sarah Sharp <sarah.a.sharp@linux.intel.com>,
Matthew Wilcox <willy@linux.intel.com>,
Ming Lei <tom.leiming@gmail.com>,
Jacob Pan <jacob.jun.pan@intel.com>,
Olof Johansson <olof@lixom.net>,
Erik Gilling <konkers@android.com>,
Colin Cross <ccross@android.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] Align tegra-ehci DMA transfers to 32B
Date: Fri, 17 Dec 2010 14:32:27 -0800 [thread overview]
Message-ID: <20101217223227.GA19418@suse.de> (raw)
In-Reply-To: <1292623129-26361-1-git-send-email-rmorell@nvidia.com>
On Fri, Dec 17, 2010 at 01:58:47PM -0800, Robert Morell wrote:
> This small set of patches fixes an issue where DMA from the tegra EHCI
> controller could be corrupted. It was most commonly seen with USB network
> adapters, though in theory it could happen with any USB traffic.
>
> (Note: An attempt was made to fix this with commit 367c3aab, which set
> NET_IP_ALIGN to 0 and NET_SKB_PAD to 32. Unfortunately, not all network
> drivers honor them (presumably since these are intended as optimizations rather
> than hard rules). This does mean that properly-written network drivers should
> fall through this code with very little overhead, however.)
We don't have many USB network drivers, why not just fix them up to
handle this properly, then you will not need to change any core USB
code, right?
thanks,
greg k-h
next prev parent reply other threads:[~2010-12-17 22:32 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-17 21:58 [RFC] Align tegra-ehci DMA transfers to 32B Robert Morell
2010-12-17 21:58 ` [PATCH 1/2] USB: Add driver hooks for (un)?map_urb_for_dma Robert Morell
2010-12-17 21:58 ` [PATCH 2/2] USB: ehci: tegra: Align DMA transfers to 32 bytes Robert Morell
2010-12-17 22:35 ` Greg KH
2010-12-17 22:42 ` rmorell
2010-12-17 23:09 ` Greg KH
2010-12-17 23:17 ` Oliver Neukum
2010-12-17 23:35 ` Greg KH
2010-12-17 23:50 ` rmorell
2010-12-17 23:40 ` rmorell
2010-12-18 0:37 ` Greg KH
2010-12-18 1:29 ` rmorell
2010-12-17 22:32 ` Greg KH [this message]
2010-12-17 22:44 ` [RFC] Align tegra-ehci DMA transfers to 32B rmorell
2010-12-17 23:07 ` Greg KH
2010-12-17 23:07 ` David Brownell
2010-12-18 1:49 ` [PATCH v2] " Robert Morell
2010-12-19 21:38 ` [PATCH] " Robert Morell
2011-01-06 23:20 ` [PATCH v4] " Robert Morell
2011-01-20 21:41 ` [PATCH v5] " Robert Morell
2011-01-27 3:06 ` [PATCH v6] " Robert Morell
2011-01-27 3:06 ` [PATCH 1/3] USB: HCD: Add usb_hcd prefix to exported functions Robert Morell
2011-01-27 16:01 ` Alan Stern
2011-01-27 3:06 ` [PATCH 2/3] USB: HCD: Add driver hooks for (un)?map_urb_for_dma Robert Morell
2011-01-27 16:01 ` Alan Stern
2011-01-27 3:06 ` [PATCH 3/3] USB: ehci: tegra: Align DMA transfers to 32 bytes Robert Morell
2011-02-04 19:49 ` Greg KH
[not found] ` <20110204194954.GA25180-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2011-02-04 20:14 ` Olof Johansson
2011-02-04 20:14 ` Olof Johansson
[not found] ` <AANLkTinRtch4Pvr3GLz5wZU2xkG3FMJxxzSNAdParA7j-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-02-04 20:16 ` Greg KH
2011-02-04 20:16 ` Greg KH
[not found] ` <20110204201616.GA12482-l3A5Bk7waGM@public.gmane.org>
2011-02-04 20:26 ` rmorell-DDmLM1+adcrQT0dZR+AlfA
2011-02-04 20:26 ` rmorell
[not found] ` <20110204202640.GC1744-f3YH7lVHJt/FT5IIyIEb6QC/G2K4zDHf@public.gmane.org>
2011-02-04 20:35 ` Greg KH
2011-02-04 20:35 ` Greg KH
2011-01-20 21:41 ` [PATCH 1/2] USB: HCD: Add driver hooks for (un)?map_urb_for_dma Robert Morell
2011-01-23 3:46 ` Greg KH
2011-01-24 16:32 ` Alan Stern
2011-01-20 21:41 ` [PATCH 2/2] USB: ehci: tegra: Align DMA transfers to 32 bytes Robert Morell
2011-01-24 16:36 ` Alan Stern
2011-01-24 22:53 ` rmorell
2011-01-25 2:59 ` Alan Stern
2011-01-06 23:20 ` [PATCH v4 1/2] USB: HCD: Add driver hooks for (un)?map_urb_for_dma Robert Morell
2011-01-06 23:20 ` [PATCH v4 2/2] USB: ehci: tegra: Align DMA transfers to 32 bytes Robert Morell
2010-12-19 21:38 ` [PATCH 1/2] USB: Add driver hooks for (un)?map_urb_for_dma Robert Morell
2010-12-19 21:38 ` [PATCH 2/2] USB: ehci: tegra: Align DMA transfers to 32 bytes Robert Morell
2010-12-19 21:57 ` Oliver Neukum
2010-12-18 1:49 ` [PATCH v2 1/2] USB: Add driver hooks for (un)?map_urb_for_dma Robert Morell
2010-12-18 17:51 ` Greg KH
2010-12-18 1:49 ` [PATCH v2 2/2] USB: ehci: tegra: Align DMA transfers to 32 bytes Robert Morell
2010-12-18 17:52 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101217223227.GA19418@suse.de \
--to=gregkh@suse.de \
--cc=benoit@android.com \
--cc=ccross@android.com \
--cc=dbrownell@users.sourceforge.net \
--cc=jacob.jun.pan@intel.com \
--cc=konkers@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rmorell@nvidia.com \
--cc=sarah.a.sharp@linux.intel.com \
--cc=stern@rowland.harvard.edu \
--cc=tom.leiming@gmail.com \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.