From: David Miller <davem@davemloft.net>
To: tj@kernel.org
Cc: mchan@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next-2.6] bnx2: remove cancel_work_sync() from remove_one
Date: Tue, 21 Dec 2010 12:20:00 -0800 (PST) [thread overview]
Message-ID: <20101221.122000.183069341.davem@davemloft.net> (raw)
In-Reply-To: <20101221105103.GA32744@htj.dyndns.org>
From: Tejun Heo <tj@kernel.org>
Date: Tue, 21 Dec 2010 11:51:04 +0100
> Yeah, I agree the synchronize_rcu() there would guarantee the actual
> timer completion but as it currently stands it looks a bit too subtle.
> Maybe it's a good idea to add a big fat comment explaining that the
> the timer is guaranteed to stop after close() and how it's guaranteed
> through synchronize_rcu() at the moment? Also, it might be better to
> use synchronize_sched() there as timer synchronization through
> synchronize_rcu() is more of a happy accident.
I'm not sure the synchronize_*() is even necessary to guarentee
watchdog timer completion.
Like I said, I think the netif_tx_lock() held around both the timer
function itself, and the del_timer() call, are sufficient.
So, this ensures that the watchdog timer either runs to completion or
sees the no-op scheduler attached and returns immediately without
rescheduling the timer.
In any event, I'm going to apply your bnx2 patch to net-next-2.6
Thanks.
next prev parent reply other threads:[~2010-12-21 20:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 16:09 [PATCH net-next-2.6] bnx2: remove cancel_work_sync() from remove_one Tejun Heo
2010-12-14 17:48 ` Michael Chan
2010-12-15 13:52 ` Tejun Heo
2010-12-20 21:11 ` David Miller
2010-12-21 10:51 ` Tejun Heo
2010-12-21 20:20 ` David Miller [this message]
2010-12-22 8:48 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101221.122000.183069341.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.