From mboxrd@z Thu Jan 1 00:00:00 1970
From: bugzilla-daemon@bugzilla.kernel.org
Subject: [Bug 25352] resizing ext4 will corrupt filesystem
Date: Tue, 21 Dec 2010 13:10:29 GMT
Message-ID: <201012211310.oBLDAT2n021131@demeter1.kernel.org>
References:
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
To: linux-ext4@vger.kernel.org
Return-path:
Received: from demeter1.kernel.org ([140.211.167.39]:36576 "EHLO
demeter1.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S1750987Ab0LUNKa convert rfc822-to-8bit (ORCPT
); Tue, 21 Dec 2010 08:10:30 -0500
Received: from demeter1.kernel.org (localhost.localdomain [127.0.0.1])
by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id oBLDATrQ021132
(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)
for ; Tue, 21 Dec 2010 13:10:29 GMT
In-Reply-To:
Sender: linux-ext4-owner@vger.kernel.org
List-ID:
https://bugzilla.kernel.org/show_bug.cgi?id=25352
--- Comment #6 from Lukas Czerner 2010-12-21 13:10:28 ---
On Mon, 20 Dec 2010, Ted Ts'o wrote:
> On Mon, Dec 20, 2010 at 08:56:46PM +0000, bugzilla-daemon@bugzilla.kernel.org wrote:
> >
> > Using resize2fs on an ext4 will result in a corrupted filesystem. This is a
> > regression (obviously).
>
> Yes, this is a regression new to 2.6.37-rc1, which was introduced by
> commit a31437b85: ext4: use sb_issue_zeroout in setup_new_group_blocks.
>
> When we replaced the loop zero'ing the inode table blocks with
> sb_issue_zeroout, we accidentally also removed this little tidbit:
>
> - ext4_set_bit(bit, bh->b_data);
>
> ... which was responsible for setting the block allocation bitmap to
> reserve the block descriptor blocks and inode table blocks. Oops...
>
> I believe this patch should fix things.
>
> - Ted
>
>
>
Oops indeed. Ted, thanks for the patch, it seems to fix the problem
completely.
-Lukas
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.