From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=57803 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PXDeD-0000d3-TE
	for qemu-devel@nongnu.org; Mon, 27 Dec 2010 09:02:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1PXDeC-0002Bc-BX
	for qemu-devel@nongnu.org; Mon, 27 Dec 2010 09:02:01 -0500
Received: from mx1.redhat.com ([209.132.183.28]:20845)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1PXDeC-0002BS-3n
	for qemu-devel@nongnu.org; Mon, 27 Dec 2010 09:02:00 -0500
Date: Mon, 27 Dec 2010 16:01:38 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20101227140136.GA27055@redhat.com>
References: <1292879881$2997@local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1292879881$2997@local>
Subject: [Qemu-devel] Re: [PATCH] piix: use pci_config_set_prog_interface()
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sebastian Herbszt <herbszt@gmx.de>
Cc: qemu-devel@nongnu.org

On Mon, Dec 20, 2010 at 10:18:01PM +0100, Sebastian Herbszt wrote:
> Use pci_config_set_prog_interface().
> 
> Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>

Since I was asked explicitly - I don't have a problem
with these changes: both class and prog interface.
However, they aren't all that useful in themselves.

For class, what I would like to see is a system where
the device class is put in the qdev info table,
and where -device ?
(and hopefully the legacy -help, -nic etc as well)
use this information.
pci_config_set_prog_interface can then have an assert to
verify that value.
Maybe we can even make e.g. -device nic work.

In a similar way, pci_config_set_prog_interface
would really become useful if we put the handling
for the legacy classes in a central place
(e.g. pci_class.c)

Any chance of doing something like the above?
I'd be happy to apply such patches.

> diff --git a/hw/ide/piix.c b/hw/ide/piix.c
> index 1cad906..2772e08 100644
> --- a/hw/ide/piix.c
> +++ b/hw/ide/piix.c
> @@ -135,7 +135,7 @@ static int pci_piix_ide_initfn(PCIIDEState *d)
>  {
>      uint8_t *pci_conf = d->dev.config;
>  
> -    pci_conf[PCI_CLASS_PROG] = 0x80; // legacy ATA mode
> +    pci_config_set_prog_interface(pci_conf, 0x80); // legacy ATA mode
>      pci_config_set_class(pci_conf, PCI_CLASS_STORAGE_IDE);
>  
>      qemu_register_reset(piix3_reset, d);
>