From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Mon, 10 Jan 2011 23:43:01 +0100
Subject: [U-Boot] [PATCH] mpq101: initial support for Mercury Computer
	Systems MPQ101 board
In-Reply-To: <754013.38475.qm@web37602.mail.mud.yahoo.com>
References: <754013.38475.qm@web37602.mail.mud.yahoo.com>
Message-ID: <20110110224301.623F1140695@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Alex Dubov,

In message <754013.38475.qm@web37602.mail.mud.yahoo.com> you wrote:
> > You should use get_ram_size().
> 
> I still need to call setup_ddr_tlbs because get_ram_size won't do it for
> me. So what get_ram_size actually does?

It checks the size of available memory and performs a simple, fast
and non-destuctive memory test on the way.

> > NAK.? Please use proper I/O accessors.
> 
> Do you mean out_be32 and friends?

Right.

> In which case, why are not these used when writing config values to DDR
> registers (for instance) even in some very recently added boards, such as
> p2020ds?

Because this escaped review?

Can you please point out where this was missed, so it can be fixed?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The universe, they said, depended for its operation on the balance of
four forces which they identified as charm,  persuasion,  uncertainty
and bloody-mindedness.      -- Terry Pratchett, "The Light Fantastic"