From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Mon, 10 Jan 2011 23:56:22 +0100 Subject: [U-Boot] [PATCH v3] mpq101: initial support for Mercury Computer Systems MPQ101 board In-Reply-To: <294951.51594.qm@web37601.mail.mud.yahoo.com> References: <294951.51594.qm@web37601.mail.mud.yahoo.com> Message-ID: <20110110225622.7C383150A4A@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Alex Dubov, In message <294951.51594.qm@web37601.mail.mud.yahoo.com> you wrote: > Mpq101 is a RapidIO development board in AMC form factor, featuring MPC8548 > processor, 512MB of hardwired DDR2 RAM, 128MB of hardwired NAND flash > memory, real time clock and additional serial EEPROM on i2c bus (enabled). > USB controller is available, but not presently enabled. > > Additional board information is available at: > http://www.mc.com/products/boards/ensemble_mpq101_rapidio_powerquicc_iii.aspx > > Environment is configured to preceed the actual u-boot image so that it's > located at the beginning of flash erase block (made necessary by the recent > changes to the embedded environment handling). > > Signed-off-by: Alex Dubov > --- > MAINTAINERS | 3 + > board/mercury/mpq101/Makefile | 53 +++++ > board/mercury/mpq101/config.mk | 6 + > board/mercury/mpq101/law.c | 55 ++++++ > board/mercury/mpq101/mpq101.c | 146 ++++++++++++++ > board/mercury/mpq101/tlb.c | 82 ++++++++ > boards.cfg | 1 + > include/configs/mpq101.h | 410 ++++++++++++++++++++++++++++++++++++++++ > 8 files changed, 756 insertions(+), 0 deletions(-) > create mode 100644 board/mercury/mpq101/Makefile > create mode 100644 board/mercury/mpq101/config.mk > create mode 100644 board/mercury/mpq101/law.c > create mode 100644 board/mercury/mpq101/mpq101.c > create mode 100644 board/mercury/mpq101/tlb.c > create mode 100644 include/configs/mpq101.h I'm not going to review this again. Why don't you explain what was changed compared to the previous version? Please see the second bullet at http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions for a detailed explanation. And you still have a board/mercury/mpq101/config.mk even though I asked you to get rid of it. Please also run your patch through checkpatch.pl, remove C++ comments, remove deads code, do not #undef variables that are not #defined, use TAB for vertical alignment and fix other Coding Style issues. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de How can you tell when sour cream goes bad?