From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=36844 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PfAgM-0003NO-9Z
	for qemu-devel@nongnu.org; Tue, 18 Jan 2011 07:29:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hch@lst.de>) id 1PfAgK-0003wS-KW
	for qemu-devel@nongnu.org; Tue, 18 Jan 2011 07:29:06 -0500
Received: from verein.lst.de ([213.95.11.210]:35047)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <hch@lst.de>)
	id 1PfAgK-0003ui-95
	for qemu-devel@nongnu.org; Tue, 18 Jan 2011 07:29:04 -0500
Date: Tue, 18 Jan 2011 13:28:56 +0100
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command
Message-ID: <20110118122856.GA28050@lst.de>
References: <20110114162044.GA19114@lst.de> <20110114162057.GA19184@lst.de>
	<4D347E0F.4040000@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4D347E0F.4040000@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, qemu-devel@nongnu.org

On Mon, Jan 17, 2011 at 06:36:15PM +0100, Kevin Wolf wrote:
> size should be 'o' instead of 'l'. The latter may be too small on 32 bit
> hosts and doesn't support convenient suffixes:

Fixed.

> Hm, is there a real reason except that CD-ROMs are read-only? The code
> below seems to take read-only devices into account.

I've removed the CDROM check for the next version.