From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=34674 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PfAyn-0005XC-6Q for qemu-devel@nongnu.org; Tue, 18 Jan 2011 07:48:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PfAym-0008UG-3K for qemu-devel@nongnu.org; Tue, 18 Jan 2011 07:48:09 -0500 Received: from verein.lst.de ([213.95.11.210]:33129) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PfAyl-0008Tu-Ps for qemu-devel@nongnu.org; Tue, 18 Jan 2011 07:48:08 -0500 Date: Tue, 18 Jan 2011 13:48:06 +0100 From: Christoph Hellwig Subject: Re: [Qemu-devel] [PATCH 0/3] allow online resizing of block devices Message-ID: <20110118124806.GA28638@lst.de> References: <20110114162044.GA19114@lst.de> <20110118103539.131ee08a@doriath> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110118103539.131ee08a@doriath> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel@nongnu.org, Markus Armbruster On Tue, Jan 18, 2011 at 10:35:39AM -0200, Luiz Capitulino wrote: > Well, what happens is this: we screwed up with that interface and we > should replace it soon. > > I see you're not adding the new command in QMP (only in the human monitor), > is that intentional? (qmp commands are added to the qmp-commands.hx file). > > If it's intentional, then using only error_report() should be ok. If you > plan to have a qmp version, then we'll have to choose between reporting > a generic error version to the client, which is what's going to happen if > you use error_report(), or add the QERR_ macros. No, I hoped this would also add the QMP interface. Why do we need to declare the commands twice? Especially as hmp-commands.hx is full of magic that makes little sense only for human readable commands. Any help on how to define the QERR_ macros?