From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=47717 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pfr2Z-0001GT-57 for qemu-devel@nongnu.org; Thu, 20 Jan 2011 04:42:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pfr2X-0003hF-GH for qemu-devel@nongnu.org; Thu, 20 Jan 2011 04:42:50 -0500 Received: from verein.lst.de ([213.95.11.210]:59299) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pfr2X-0003h5-2G for qemu-devel@nongnu.org; Thu, 20 Jan 2011 04:42:49 -0500 Date: Thu, 20 Jan 2011 10:42:47 +0100 From: Christoph Hellwig Message-ID: <20110120094247.GA3472@lst.de> References: <20110119170238.GA9615@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: [Qemu-devel] Re: [PATCH 0/3 v2] allow online resizing of block devices List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: Christoph Hellwig , qemu-devel@nongnu.org On Wed, Jan 19, 2011 at 06:26:49PM +0100, Juan Quintela wrote: > Does this handle the change of the rtc data? I can't see how/where. > (Not that I know if it is important at all until reboot). It doesn't. > cmos_init_hb() uses the size to guess the right geometry of the drives, > if we change the size of the drive, should we change that one? I don't think changing geometry on a live system is a good idea. But as mentioned at least for Linux guests there's no way to find out about the new size of an IDE disk right now. Although I might send a patch to allow a manual rescan, similar to SCSI.