From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=57483 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PgCzW-0007qc-7g for qemu-devel@nongnu.org; Fri, 21 Jan 2011 04:09:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PgCzV-0004Bc-4C for qemu-devel@nongnu.org; Fri, 21 Jan 2011 04:09:10 -0500 Received: from mail-bw0-f45.google.com ([209.85.214.45]:42459) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PgCzU-0004B8-S5 for qemu-devel@nongnu.org; Fri, 21 Jan 2011 04:09:09 -0500 Received: by bwz16 with SMTP id 16so1308744bwz.4 for ; Fri, 21 Jan 2011 01:09:07 -0800 (PST) Date: Fri, 21 Jan 2011 09:08:49 +0000 From: Stefan Hajnoczi Subject: Re: [Qemu-devel] [PATCH 0/5] -drive/drive_add fixes Message-ID: <20110121090849.GA14152@stefanha-thinkpad.localdomain> References: <1295289090-18236-1-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1295289090-18236-1-git-send-email-armbru@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, qemu-devel@nongnu.org On Mon, Jan 17, 2011 at 07:31:25PM +0100, Markus Armbruster wrote: > Note: PATCH 3/5 makes -drive reject duplicate definitions instead of > ignoring all but the first silently. If this isn't sufficiently > bug-compatible for you, we need to talk. > > Markus Armbruster (5): > blockdev: Fix error message for invalid -drive CHS > blockdev: Make drive_init() use error_report() > blockdev: Reject multiple definitions for the same drive > blockdev: Fix drive_del not to crash when drive is not in use > blockdev: Fix drive_add for drives without media > > blockdev.c | 88 ++++++++++++++++++++++++-------------------------- > blockdev.h | 2 +- > hw/device-hotplug.c | 3 +- > hw/usb-msd.c | 3 +- > vl.c | 6 +-- > 5 files changed, 47 insertions(+), 55 deletions(-) Reviewed-by: Stefan Hajnoczi