From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ted Ts'o Subject: Re: [PATCH 0/7] Nexus One Support Date: Fri, 21 Jan 2011 18:49:30 -0500 Message-ID: <20110121234930.GK3043@thunk.org> References: <1295576730.4096.24.camel@Joe-Laptop> <1295624801.19880.13.camel@m0nster> <20110121094827.41818a55@jbarnes-desktop> <20110121095658.1ab623fe@jbarnes-desktop> <1295632828.19880.22.camel@m0nster> <20110121100441.06a94482@jbarnes-desktop> <1295633882.19880.31.camel@m0nster> <1295642995.19880.42.camel@m0nster> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from THUNK.ORG ([69.25.196.29]:58730 "EHLO thunker.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753975Ab1AUXtj (ORCPT ); Fri, 21 Jan 2011 18:49:39 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Pekka Enberg Cc: Daniel Walker , Dima Zavin , Jesse Barnes , Joe Perches , linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, davidb@codeaurora.org On Fri, Jan 21, 2011 at 11:05:54PM +0200, Pekka Enberg wrote: > > On Fri, Jan 21, 2011 at 10:49 PM, Daniel Walker wrote: > > I'll add this list into the commit text .. > > So why is everyone bitching at Daniel when he's doing something the > Android folks should have done themselves a long time ago? Two wrongs don't make a right. And it's not like not submitting changes is wrong, although granted it's not ideal. (I'd say removing attribution from a git commit is even worse. If you're doing the equivalent of a cherry pick, you should preserve the Author field. Even if you're doing some cleanup work, as the maintainer I generally preserve the Author line, and will simply add the fact that I did some cleanup to the commit body. The question is who did more work; the person who originally submitted the code, or the person who did the cleanup.) - Ted From mboxrd@z Thu Jan 1 00:00:00 1970 From: tytso@mit.edu (Ted Ts'o) Date: Fri, 21 Jan 2011 18:49:30 -0500 Subject: [PATCH 0/7] Nexus One Support In-Reply-To: References: <1295576730.4096.24.camel@Joe-Laptop> <1295624801.19880.13.camel@m0nster> <20110121094827.41818a55@jbarnes-desktop> <20110121095658.1ab623fe@jbarnes-desktop> <1295632828.19880.22.camel@m0nster> <20110121100441.06a94482@jbarnes-desktop> <1295633882.19880.31.camel@m0nster> <1295642995.19880.42.camel@m0nster> Message-ID: <20110121234930.GK3043@thunk.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Jan 21, 2011 at 11:05:54PM +0200, Pekka Enberg wrote: > > On Fri, Jan 21, 2011 at 10:49 PM, Daniel Walker wrote: > > I'll add this list into the commit text .. > > So why is everyone bitching at Daniel when he's doing something the > Android folks should have done themselves a long time ago? Two wrongs don't make a right. And it's not like not submitting changes is wrong, although granted it's not ideal. (I'd say removing attribution from a git commit is even worse. If you're doing the equivalent of a cherry pick, you should preserve the Author field. Even if you're doing some cleanup work, as the maintainer I generally preserve the Author line, and will simply add the fact that I did some cleanup to the commit body. The question is who did more work; the person who originally submitted the code, or the person who did the cleanup.) - Ted