All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: Andy Walls <awalls@md.metrocast.net>
Cc: linux-media@vger.kernel.org
Subject: Re: v4l2-compliance utility
Date: Sat, 22 Jan 2011 09:52:18 +0100	[thread overview]
Message-ID: <201101220952.18293.hverkuil@xs4all.nl> (raw)
In-Reply-To: <1295652919.2474.14.camel@localhost>

On Saturday, January 22, 2011 00:35:19 Andy Walls wrote:
> On Fri, 2011-01-21 at 23:37 +0100, Hans Verkuil wrote:
> > Hi all,
> > 
> > As you may have seen I have been adding a lot of tests to the v4l2-compliance
> > utility in v4l-utils lately. It is now getting to the state that is becomes
> > quite useful even though there is no full coverage yet.
> > 
> > Currently the following ioctls are being tested:
> 
> Hans,
> 
> This is a great thing to have.  Thanks!
> 
> 
> > Also tested is whether you can open device nodes multiple times.
> > 
> > These tests are pretty exhaustive and more strict than the spec itself.
> 
> OK, so multiple open is not strictly required by the spec, IIRC.  If you
> check the ivtv /dev/radio node, it does not allow multiple open, IIRC,
> so it should not get OK for that test.

And indeed it fails on that test.

> I also think during the subdev conversion, some of the less popular ivtv
> cards with GPIO controlled radio audio may have been broken (and still
> not fixed yet :(  ), but working for the PVR-150, PVR-500, etc..

What the tool does not do of course is test if your driver actually works.
So it tests if you can e.g. set the audio output to some value, but whether
you actually get audio on that output is a completely separate matter :-)
 
> The DEBUG ioctl()s can be compiled out too.

In that case the tool should report 'Not Supported'.

> 
> So for someone making decisions based on the output of this tool:
> 
> 1. if something comes back as "Not supported", that still means the
> driver is API specification compliant, right?

Yes. And as far as the compliance tool is concerned the driver tells it
that it doesn't support that particular API. E.g. a card without a tuner
should report 'Not Supported' for the S/G_TUNER tests.

> 2. could it be the case that this compliance tool will be sensitive to
> the driver/hardware combination and not the driver alone?

Definitely. If certain features (e.g. a tuner) are only available on certain
cards, then the tool can only test what the hardware you use at the moment
supports.

The utility tests whether, for the current kernel configuration, driver and
hardware, the V4L2 device node works as it should.

Regards,

	Hans

-- 
Hans Verkuil - video4linux developer - sponsored by Cisco

      reply	other threads:[~2011-01-22  8:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-21 22:37 v4l2-compliance utility Hans Verkuil
2011-01-21 23:35 ` Andy Walls
2011-01-22  8:52   ` Hans Verkuil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201101220952.18293.hverkuil@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=awalls@md.metrocast.net \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.