From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH 0/7] Nexus One Support Date: Sat, 22 Jan 2011 18:49:09 +0000 Message-ID: <20110122184909.GB11960@n2100.arm.linux.org.uk> References: <1295632828.19880.22.camel@m0nster> <20110121100441.06a94482@jbarnes-desktop> <1295633882.19880.31.camel@m0nster> <1295642995.19880.42.camel@m0nster> <1295643762.25868.31.camel@Joe-Laptop> <1295645098.22882.1.camel@m0nster> <20110122122018.GC5194@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from caramon.arm.linux.org.uk ([78.32.30.218]:53483 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750872Ab1AVSte (ORCPT ); Sat, 22 Jan 2011 13:49:34 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Dima Zavin Cc: Pekka Enberg , Daniel Walker , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Jesse Barnes , Joe Perches , davidb@codeaurora.org, linux-arm-kernel@lists.infradead.org On Sat, Jan 22, 2011 at 10:06:44AM -0800, Dima Zavin wrote: > All I ask is that if files are directly copied out of the tree with > only slight modifications or if they are copied and stripped down for > easier consumption, just say > Original Authors: if it's reasonable to gather who the > primary contributors are. If that is hard due to lots of commits and > squashes, even a Cc: to the people who wrote the code would have been > enough. Had any of that been done, I would have not said a word. Well, having read what Thomas said in his mail: Thomas said: | Patch 3/7 is extracted from another large dump (37431502c4) in the | android tree which has: [diffstat summary cut] | And if you look at the above 37431502c4 commit then you'll notice tha= t | the author is Dima Zavin , while in fact the whole | commit is a conglomerate of commits from some other place with 16 | different authors, but there is no way to identify who wrote what. I decided to investigate: http://android.git.kernel.org/?p=3Dkernel/msm.git;a=3Dcommit;h=3D374315= 02c4 | author Dima Zavin | committer Arve Hj=F8nnev=E5g | | [ARM] msm: mahimahi: Update the memory map. |=20 | - move framebuffer to SMI and mdp pmem to bank 2 of EBI | - remove the gpu pmem regions since we now use the MMU | - move the adsp region to bank 2, and make it bigger (41MB vs 32MB) | - move ram console to SMI |=20 | Change-Id: I88b4033e98374fc038609fbbb1c7e5cbed4f87c4 | Signed-off-by: Dima Zavin |=20 | [ARM] msm: mahimahi: Expand memory available to kernel to 219MB |=20 | Change-Id: I59e69ce4209d16ce9804d3fa81814c9d0bda9a03 | Signed-off-by: Dima Zavin |=20 | [ARM] msm: mahimahi: Read bluetooth address from ATAG and export in s= ysfs. |=20 | Signed-off-by: Nick Pelly =2E.. etc ... Those change IDs are meaningless, they provide no way for external peop= le to trace the history of the original commits and work out who did what in the resulting diff. Maybe you could illustrate how to take that particular commit, which Daniel apparantly based his 3/7 patch on, and identify who Daniel shoul= d and should not give credit to using *just* the text in that commit and no other information. If you can't do that without reference to some other information, then = I don't think you have a leg to stand on when complaining to Daniel about not giving credit, as you've made it impossible for that to happen. While it is not fair _not_ to give credit to people who worked on a particular piece of code, it is also not fair _to_ give credit to people who didn't work on that same code. It erodes the value of crediting the real authors. I'd say that Daniel is doing a bloody good job, everything considered. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752070Ab1AVSth (ORCPT ); Sat, 22 Jan 2011 13:49:37 -0500 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:53484 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751055Ab1AVStg (ORCPT ); Sat, 22 Jan 2011 13:49:36 -0500 Date: Sat, 22 Jan 2011 18:49:09 +0000 From: Russell King - ARM Linux To: Dima Zavin Cc: Pekka Enberg , Daniel Walker , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Jesse Barnes , Joe Perches , davidb@codeaurora.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/7] Nexus One Support Message-ID: <20110122184909.GB11960@n2100.arm.linux.org.uk> References: <1295632828.19880.22.camel@m0nster> <20110121100441.06a94482@jbarnes-desktop> <1295633882.19880.31.camel@m0nster> <1295642995.19880.42.camel@m0nster> <1295643762.25868.31.camel@Joe-Laptop> <1295645098.22882.1.camel@m0nster> <20110122122018.GC5194@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 22, 2011 at 10:06:44AM -0800, Dima Zavin wrote: > All I ask is that if files are directly copied out of the tree with > only slight modifications or if they are copied and stripped down for > easier consumption, just say > Original Authors: if it's reasonable to gather who the > primary contributors are. If that is hard due to lots of commits and > squashes, even a Cc: to the people who wrote the code would have been > enough. Had any of that been done, I would have not said a word. Well, having read what Thomas said in his mail: Thomas said: | Patch 3/7 is extracted from another large dump (37431502c4) in the | android tree which has: [diffstat summary cut] | And if you look at the above 37431502c4 commit then you'll notice that | the author is Dima Zavin , while in fact the whole | commit is a conglomerate of commits from some other place with 16 | different authors, but there is no way to identify who wrote what. I decided to investigate: http://android.git.kernel.org/?p=kernel/msm.git;a=commit;h=37431502c4 | author Dima Zavin | committer Arve Hjønnevåg | | [ARM] msm: mahimahi: Update the memory map. | | - move framebuffer to SMI and mdp pmem to bank 2 of EBI | - remove the gpu pmem regions since we now use the MMU | - move the adsp region to bank 2, and make it bigger (41MB vs 32MB) | - move ram console to SMI | | Change-Id: I88b4033e98374fc038609fbbb1c7e5cbed4f87c4 | Signed-off-by: Dima Zavin | | [ARM] msm: mahimahi: Expand memory available to kernel to 219MB | | Change-Id: I59e69ce4209d16ce9804d3fa81814c9d0bda9a03 | Signed-off-by: Dima Zavin | | [ARM] msm: mahimahi: Read bluetooth address from ATAG and export in sysfs. | | Signed-off-by: Nick Pelly ... etc ... Those change IDs are meaningless, they provide no way for external people to trace the history of the original commits and work out who did what in the resulting diff. Maybe you could illustrate how to take that particular commit, which Daniel apparantly based his 3/7 patch on, and identify who Daniel should and should not give credit to using *just* the text in that commit and no other information. If you can't do that without reference to some other information, then I don't think you have a leg to stand on when complaining to Daniel about not giving credit, as you've made it impossible for that to happen. While it is not fair _not_ to give credit to people who worked on a particular piece of code, it is also not fair _to_ give credit to people who didn't work on that same code. It erodes the value of crediting the real authors. I'd say that Daniel is doing a bloody good job, everything considered. From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@arm.linux.org.uk (Russell King - ARM Linux) Date: Sat, 22 Jan 2011 18:49:09 +0000 Subject: [PATCH 0/7] Nexus One Support In-Reply-To: References: <1295632828.19880.22.camel@m0nster> <20110121100441.06a94482@jbarnes-desktop> <1295633882.19880.31.camel@m0nster> <1295642995.19880.42.camel@m0nster> <1295643762.25868.31.camel@Joe-Laptop> <1295645098.22882.1.camel@m0nster> <20110122122018.GC5194@n2100.arm.linux.org.uk> Message-ID: <20110122184909.GB11960@n2100.arm.linux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, Jan 22, 2011 at 10:06:44AM -0800, Dima Zavin wrote: > All I ask is that if files are directly copied out of the tree with > only slight modifications or if they are copied and stripped down for > easier consumption, just say > Original Authors: if it's reasonable to gather who the > primary contributors are. If that is hard due to lots of commits and > squashes, even a Cc: to the people who wrote the code would have been > enough. Had any of that been done, I would have not said a word. Well, having read what Thomas said in his mail: Thomas said: | Patch 3/7 is extracted from another large dump (37431502c4) in the | android tree which has: [diffstat summary cut] | And if you look at the above 37431502c4 commit then you'll notice that | the author is Dima Zavin , while in fact the whole | commit is a conglomerate of commits from some other place with 16 | different authors, but there is no way to identify who wrote what. I decided to investigate: http://android.git.kernel.org/?p=kernel/msm.git;a=commit;h=37431502c4 | author Dima Zavin | committer Arve Hj?nnev?g | | [ARM] msm: mahimahi: Update the memory map. | | - move framebuffer to SMI and mdp pmem to bank 2 of EBI | - remove the gpu pmem regions since we now use the MMU | - move the adsp region to bank 2, and make it bigger (41MB vs 32MB) | - move ram console to SMI | | Change-Id: I88b4033e98374fc038609fbbb1c7e5cbed4f87c4 | Signed-off-by: Dima Zavin | | [ARM] msm: mahimahi: Expand memory available to kernel to 219MB | | Change-Id: I59e69ce4209d16ce9804d3fa81814c9d0bda9a03 | Signed-off-by: Dima Zavin | | [ARM] msm: mahimahi: Read bluetooth address from ATAG and export in sysfs. | | Signed-off-by: Nick Pelly ... etc ... Those change IDs are meaningless, they provide no way for external people to trace the history of the original commits and work out who did what in the resulting diff. Maybe you could illustrate how to take that particular commit, which Daniel apparantly based his 3/7 patch on, and identify who Daniel should and should not give credit to using *just* the text in that commit and no other information. If you can't do that without reference to some other information, then I don't think you have a leg to stand on when complaining to Daniel about not giving credit, as you've made it impossible for that to happen. While it is not fair _not_ to give credit to people who worked on a particular piece of code, it is also not fair _to_ give credit to people who didn't work on that same code. It erodes the value of crediting the real authors. I'd say that Daniel is doing a bloody good job, everything considered.