From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from coco.kroah.org (kroah.org [198.145.64.141]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "coco.kroah.org", Issuer "Greg KH" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 87F27B710F for ; Sun, 23 Jan 2011 19:18:18 +1100 (EST) Date: Sat, 22 Jan 2011 19:01:50 -0800 From: Greg KH To: tmarri@apm.com Subject: Re: [PATCH V8 00/10] Add-Synopsys-DesignWare-HS-USB-OTG-driver Message-ID: <20110123030150.GA28358@kroah.com> References: <1295477836-14589-1-git-send-email-tmarri@apm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1295477836-14589-1-git-send-email-tmarri@apm.com> Cc: linux-usb@vger.kernel.org, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Jan 19, 2011 at 02:57:16PM -0800, tmarri@apm.com wrote: > From: Tirumala Marri > > v8: > 1. Add set_wedge to usb_ep_ops. > > v7: > 1. Fix sparse tool warnings. > 2. Fix checkpatch errors and warnings. > 3. Rename USB_OTG config variable to USB_DWC_CONFIG > > Tirumala Marri (10): > USB/ppc4xx: Add Synopsys DWC OTG Register definitions > USB/ppc4xx: Add Synopsys DWC OTG driver framework > USB/ppc4xx: Add Synopsys DWC OTG Core Interface Layer > USB/ppc4xx: Add Synopsys DWC OTG HCD function > USB/ppc4xx: Add Synopsys DWC OTG HCD interrupt function > USB/ppc4xx: Add Synopsys DWC OTG HCD queue function > USB/ppc4xx: Add Synopsys DWC OTG PCD function > USB ppc4xx: Add Synopsys DWC OTG PCD interrupt function > USB/ppc4xx:Synopsys DWC OTG driver enable gadget support > USB ppc4xx: Add Synopsys DWC OTG driver kernel configuration and > Makefile > > drivers/Makefile | 2 + > drivers/usb/Kconfig | 3 +- > drivers/usb/dwc_otg/Kconfig | 96 ++ Why are you creating a new subdirectory here? Shouldn't it be in drivers/usb/otg/dwc/ instead? > drivers/usb/dwc_otg/Makefile | 19 + > drivers/usb/dwc_otg/dwc_otg_apmppc.c | 414 ++++++ > drivers/usb/dwc_otg/dwc_otg_cil.c | 972 ++++++++++++ > drivers/usb/dwc_otg/dwc_otg_cil.h | 1220 +++++++++++++++ > drivers/usb/dwc_otg/dwc_otg_cil_intr.c | 616 ++++++++ > drivers/usb/dwc_otg/dwc_otg_driver.h | 76 + > drivers/usb/dwc_otg/dwc_otg_hcd.c | 2466 +++++++++++++++++++++++++++++++ > drivers/usb/dwc_otg/dwc_otg_hcd.h | 416 ++++++ > drivers/usb/dwc_otg/dwc_otg_hcd_intr.c | 1477 ++++++++++++++++++ > drivers/usb/dwc_otg/dwc_otg_hcd_queue.c | 696 +++++++++ > drivers/usb/dwc_otg/dwc_otg_param.c | 180 +++ > drivers/usb/dwc_otg/dwc_otg_pcd.c | 1766 ++++++++++++++++++++++ > drivers/usb/dwc_otg/dwc_otg_pcd.h | 139 ++ > drivers/usb/dwc_otg/dwc_otg_pcd_intr.c | 2311 +++++++++++++++++++++++++++++ > drivers/usb/dwc_otg/dwc_otg_regs.h | 1325 +++++++++++++++++ As you are in your own subdir, no need to put "dwc_otg_" at the start of every file name, right? Care to make these changes and resend? thanks, greg k-h