From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH 0/11] ACPI: Fixes and cleanups related to iomaps management Date: Sun, 23 Jan 2011 21:28:02 +0100 Message-ID: <201101232128.03007.rjw@sisk.pl> References: <201101201226.41021.rjw@sisk.pl> <201101222012.14028.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from ogre.sisk.pl ([217.79.144.158]:43710 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752128Ab1AWU2c (ORCPT ); Sun, 23 Jan 2011 15:28:32 -0500 In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Jeff Chua Cc: Len Brown , LKML , ACPI Devel Maling List , Linux-pm mailing list , Matthew Garrett On Sunday, January 23, 2011, Jeff Chua wrote: > On Sun, Jan 23, 2011 at 3:12 AM, Rafael J. Wysocki wrote: > > On Saturday, January 22, 2011, Jeff Chua wrote: > >> 2011/1/22 Rafael J. Wysocki : > >> > On Saturday, January 22, 2011, Jeff Chua wrote: > >> > >> > means that my patch [11/11] _and_ the replacement are totally wrong, because you have > >> > _multiple_ NVS regions. That really helped, thanks a lot. > >> > >> Would it be different if I offline all CPUs before suspending to ram? > >> It seems to help with suspending to disk. > > > > No, that doesn't matter. NVS regions are just sitting there regardless of > > what happens at run time. > > Strange. If I didn't offline, it hanged during suspend even without > thinkpad_acpi. I could see that the suspend code does the offline > automatically, but executing the offline before calling suspend makes > it no hanging. That means there's a problem in the CPU hotplug code that manifests itslef during suspend. Is this 100% reproducible? Did it happen with 2.6.37? Rafael