From: David Miller <davem@davemloft.net>
To: jj@chaosbits.net
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, gregkh@suse.de, zapman@interlan.net,
rothwell@interlan.net
Subject: Re: [PATCH] USB NET KL5KUSB101: Fix mem leak in error path of kaweth_download_firmware()
Date: Mon, 24 Jan 2011 23:20:35 -0800 (PST) [thread overview]
Message-ID: <20110124.232035.183057878.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LNX.2.00.1101232315230.30955@swampdragon.chaosbits.net>
From: Jesper Juhl <jj@chaosbits.net>
Date: Sun, 23 Jan 2011 23:19:55 +0100 (CET)
> We will leak the storage allocated by request_firmware() if the size of
> the firmware is greater than KAWETH_FIRMWARE_BUF_SIZE.
> This removes the leak by calling release_firmware() before we return
> -ENOSPC.
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Applied, thanks Jesper.
prev parent reply other threads:[~2011-01-25 7:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-23 22:19 [PATCH] USB NET KL5KUSB101: Fix mem leak in error path of kaweth_download_firmware() Jesper Juhl
2011-01-25 7:20 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110124.232035.183057878.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=jj@chaosbits.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rothwell@interlan.net \
--cc=zapman@interlan.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.