All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Wojcik <krzysztof.wojcik@intel.com>
To: neilb@suse.de
Cc: linux-raid@vger.kernel.org, wojciech.neubauer@intel.com,
	adam.kwolek@intel.com, dan.j.williams@intel.com,
	ed.ciechanowski@intel.com
Subject: [PATCH 5/5] FIX: Validate input in ping_manager function
Date: Mon, 24 Jan 2011 15:17:37 +0100	[thread overview]
Message-ID: <20110124141737.16405.95572.stgit@gklab-128-111.igk.intel.com> (raw)
In-Reply-To: <20110124141704.16405.6081.stgit@gklab-128-111.igk.intel.com>

For native case we do not have manager running so we have to
return without pinging.
Moreover we have NULL as input parameter. We should to avoid
segmentation fault.

Signed-off-by: Krzysztof Wojcik <krzysztof.wojcik@intel.com>
---
 msg.c |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/msg.c b/msg.c
index b97ebec..2c770ab 100644
--- a/msg.c
+++ b/msg.c
@@ -432,7 +432,13 @@ void unblock_monitor(char *container, const int unfreeze)
  */
 int ping_manager(char *devname)
 {
-	int sfd = connect_monitor(devname);
+	int sfd;
+
+	if (!devname)
+		return -1;
+
+	sfd = connect_monitor(devname);
+
 	struct metadata_update msg = { .len = -1 };
 	int err = 0;
 


  parent reply	other threads:[~2011-01-24 14:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-24 14:17 [PATCH 1/5] FIX: Unfreeze array if reshape_array wasn't succeded Krzysztof Wojcik
2011-01-24 14:17 ` [PATCH 2/5] Add raid1->raid0 takeover support Krzysztof Wojcik
2011-01-27  3:12   ` Neil Brown
2011-01-24 14:17 ` [PATCH 3/5] Mistake in raid1->raid5 migration Krzysztof Wojcik
2011-01-27  3:13   ` Neil Brown
2011-01-24 14:17 ` [PATCH 4/5] FIX: Validate input in ping_monitor function Krzysztof Wojcik
2011-01-27  3:14   ` Neil Brown
2011-01-24 14:17 ` Krzysztof Wojcik [this message]
2011-01-27  3:10 ` [PATCH 1/5] FIX: Unfreeze array if reshape_array wasn't succeded Neil Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110124141737.16405.95572.stgit@gklab-128-111.igk.intel.com \
    --to=krzysztof.wojcik@intel.com \
    --cc=adam.kwolek@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=ed.ciechanowski@intel.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=wojciech.neubauer@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.