All of lore.kernel.org
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm: Configure reference clock for Versatile Express timers
Date: Mon, 24 Jan 2011 14:47:53 +0000	[thread overview]
Message-ID: <20110124144753.GB22949@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1295373883-21513-1-git-send-email-pawel.moll@arm.com>

On Tue, Jan 18, 2011 at 06:04:43PM +0000, Pawel Moll wrote:
>  static void __init v2m_timer_init(void)
>  {
> +	u32 scctrl;
> +
>  	versatile_sched_clock_init(MMIO_P2V(V2M_SYS_24MHZ), 24000000);
>  
> -	writel(0, MMIO_P2V(V2M_TIMER0) + TIMER_CTRL);
> -	writel(0, MMIO_P2V(V2M_TIMER1) + TIMER_CTRL);
> +	/* Select 1MHz TIMCLK as the reference clock for SP804 timers */
> +	scctrl = readl(MMIO_P2V(V2M_SYSCTL + SCCTRL));
> +	scctrl |= SCCTRL_TIMEREN0SEL_TIMCLK;
> +	scctrl |= SCCTRL_TIMEREN1SEL_TIMCLK;
> +	writel(scctrl, MMIO_P2V(V2M_SYSCTL + SCCTRL));

BTW, why are you removing the initialization of TIMER_CTRL ?  You don't
describe why you do this in the commit log so I suspect it's a mistake.

  reply	other threads:[~2011-01-24 14:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-18 18:04 [PATCH v2] arm: Configure reference clock for Versatile Express timers Pawel Moll
2011-01-24 14:47 ` Russell King - ARM Linux [this message]
2011-01-24 16:12   ` Pawel Moll
2011-01-24 16:14     ` Russell King - ARM Linux
2011-01-24 16:38       ` Pawel Moll
2011-01-24 16:42         ` Russell King - ARM Linux
2011-01-24 17:10         ` Russell King - ARM Linux
2011-01-24 19:13           ` Pawel Moll
2011-01-24 20:20             ` Russell King - ARM Linux
2011-01-25 14:18               ` Pawel Moll
2011-01-25 14:38                 ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110124144753.GB22949@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.